CI fix#32
Merged
Merged
Conversation
Danny-Nosrati
approved these changes
Mar 14, 2026
Danny-Nosrati
left a comment
Danny-Nosrati
left a comment
Collaborator
There was a problem hiding this comment.
It looks logical 🔥
clay-arras
requested changes
Mar 14, 2026
clay-arras
left a comment
clay-arras
left a comment
Contributor
There was a problem hiding this comment.
hey rowan, nice PR!
added a small nit
| return result | ||
|
|
||
| def __add__(self, other: "Value") -> "Value": | ||
| def __add__(self, other: "Value" | float | int) -> "Value": |
Contributor
There was a problem hiding this comment.
small nit: you can probably define Scalar = float | int, and then replace all these instances with Scalar, like
def __add__(self, other: "Value" | Scalar) -> "Value":
just so if we ever decide to change we can edit one place.
Collaborator
Author
There was a problem hiding this comment.
that's smart will do
Closed
Collaborator
Author
|
Addressed Neil's nit in the latest push: I introduced a Scalar alias in src/common/autograd.py and replaced the repeated float | int unions. Validation still passes locally (black, mypy, ruff, pytest). |
Contributor
|
lgtm, can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation