Task 290#7
Open
megamim247 wants to merge 21 commits intomainfrom
Open
Conversation
Adjusted APPS1 and APPS2 raw min/max calibration values and set DEBUG_MODE to 2 for more verbose debugging. Added a serial log message when APPS implausibility timeout is reached to aid in diagnostics.
Possible APPS code
* Created base files for brake light * Add brake light control implementation and header file * Refactor setup and loop functions to include serial initialization and brake light control * Create tilt.py --------- Co-authored-by: Charlie Zhang <charliezhang2004@hotmail.com>
Integrated the ITEADLIB_Arduino_Nextion library for Nextion display support and added new header files: dashboard.h, helpers.h, logging.h, and motor_controller.h. Updated existing headers (apps.h, brake_light.h, header.h) to support new features and integration.
Refactored dashboard and brake light modules to use namespaces and improved function naming. Added new helper files for Nextion dashboard widgets and component IDs. Updated dashboard to support additional telemetry and sensor bar updates. Improved code documentation and organization across headers and source files. Removed unused library zip and updated timing constants for faster dashboard refresh.
Simplified MotorController::init() by removing pin arguments and internal state, now relying on global pin definitions. Replaced local BrakeData struct with alias to BrakeLight::BrakeData for consistency. Updated main.cpp and related logic to match new initialization signature and improved comments for clarity.
Introduces rtdRequestPending and tPendingReady to track pending Ready-To-Drive (RTD) requests. Refactors RTD entry logic to require both brake and RTD button, and to wait for inverter confirmation before setting readyToDrive. Adds timeout for pending RTD requests and centralizes status word handling for improved fault and state management.
Refactored the brake light and motor controller modules, updating their headers and implementations. Adjusted related application logic in main.cpp and apps.cpp to accommodate the new interfaces and improve modularity.
Excluded JetBrains IDE project files by adding .idea to .gitignore to prevent committing IDE-specific settings.
…espace style as brakedata Updated .gitignore to exclude compile_commands.json from version control. Also includes various code changes in header and source files for apps, brake light, dashboard helpers, and motor controller modules.
Introduced configurable speed limiting logic with linear taper and hysteresis, as well as a slew rate limiter to smooth torque command changes. Added related constants to header files and updated APPS/brake conflict logic to use new thresholds. These changes improve safety and drivability by preventing abrupt torque changes and enforcing speed limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.