Skip to content

Pr 2331 - #2332

Closed
klortiz13 wants to merge 2 commits into
experimentalfrom
pr-2331
Closed

Pr 2331#2332
klortiz13 wants to merge 2 commits into
experimentalfrom
pr-2331

Conversation

@klortiz13

Copy link
Copy Markdown
Contributor

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

VINERAJ added 2 commits July 27, 2026 09:34
# Conflicts:
#	lib/core/models/tgpt_models/chat_message.dart
#	lib/core/providers/chat_provider.dart
#	lib/core/services/tgpt_services/chat_stream.dart
#	lib/core/services/tgpt_services/tgpt_error_message.dart
#	lib/ui/ai_assistant/ai_assistant_view.dart
#	lib/ui/ai_assistant/chat_citation.dart
#	lib/ui/navigator/bottom.dart
@github-actions

Copy link
Copy Markdown

Code Style Violations Found

  • Static Constants (UPPER_SNAKE_CASE): 2 violations
  • Very Long If Statement Conditions: 2 violations

Total Violations: 4
Total Categories Failed: 2/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

@klortiz13

Copy link
Copy Markdown
Contributor Author

Temp PR to trigger builds in #2331

@klortiz13 klortiz13 closed this Jul 27, 2026
@klortiz13
klortiz13 deleted the pr-2331 branch July 28, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants