Skip to content

Esri build error - #2340

Closed
alberthoangg wants to merge 66 commits into
experimentalfrom
esri-build-error
Closed

Esri build error#2340
alberthoangg wants to merge 66 commits into
experimentalfrom
esri-build-error

Conversation

@alberthoangg

Copy link
Copy Markdown
Contributor

Summary

Changelog

[FIX] [GENERAL] - build error

Test Plan

klortiz13 and others added 30 commits July 27, 2026 09:02
… from including it in its component tree, so we don't waste compute power computing the drone view and all those other extra features and we keep performance high. This is possible thanks to lib/core/utils/feature_flags.dart
… on/off esri features so the campus app doesn't waste computing power to render things we won't use
klortiz13 and others added 28 commits July 29, 2026 13:00
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Code Style Violations Found

  • Static Constants (UPPER_SNAKE_CASE): 15 violations
  • Very Long If Statement Conditions: 21 violations

Total Violations: 36
Total Categories Failed: 2/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants