Skip to content

fixed iOS builds - #2344

Merged
klortiz13 merged 2 commits into
esri-map-integration-v2from
esri-build-error-klortiz13
Aug 3, 2026
Merged

fixed iOS builds#2344
klortiz13 merged 2 commits into
esri-map-integration-v2from
esri-build-error-klortiz13

Conversation

@klortiz13

Copy link
Copy Markdown
Contributor

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@UCSD UCSD deleted a comment from github-actions Bot Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Code Style Violations Found

  • Static Constants (UPPER_SNAKE_CASE): 15 violations
  • Very Long If Statement Conditions: 21 violations

Total Violations: 36
Total Categories Failed: 2/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

@klortiz13
klortiz13 merged commit e98ad86 into esri-map-integration-v2 Aug 3, 2026
1 of 2 checks passed
@klortiz13
klortiz13 deleted the esri-build-error-klortiz13 branch August 3, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant