feat: Incremental Build #1238
Draft
feat: Incremental Build #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
feat/incremental-build-2
branch
from
7d1ed69 to
9f24569
Compare
RandomByte
force-pushed
the
feat/incremental-build-2
branch
from
9f24569 to
f3f484d
Compare
d3xter666
reviewed
Dec 16, 2025
Comment on lines
+26
to
+29
| if (cacheUtil.hasCache()) { | ||
| const changedPaths = cacheUtil.getChangedProjectResourcePaths(); | ||
| resources = resources.filter((resource) => changedPaths.has(resource.getPath())); | ||
| } |
Member
There was a problem hiding this comment.
I see this pattern repeats a lot.
Wouldn't it be easier to encapsulate it as method of the cacheUtil.
packages/fs/lib/DuplexTracker.js
Outdated
|
|
||
| // TODO: Alternative name: Inspector/Interceptor/... | ||
|
|
||
| export default class Trace extends AbstractReaderWriter { |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Sadly they don't share the same superclass. AbstractReader is missing the needed writer element.
Said that, I'm also not happy with this class structure.
RandomByte
force-pushed
the
feat/incremental-build-2
branch
from
08fb5c4 to
a8b7969
Compare
…ters Cherry-picked from SAP/ui5-fs@5651627 JIRA: CPOUI5FOUNDATION-1174
Cherry-picked from: SAP/ui5-fs@5651627 JIRA: CPOUI5FOUNDATION-1174
Cherry-picked from: SAP/ui5-builder@ef5a3b2 JIRA: CPOUI5FOUNDATION-1174
Cherry-picked from: SAP/ui5-project@82b20ee JIRA: CPOUI5FOUNDATION-1174
Prerequisite for versioning support Cherry-picked from: SAP/ui5-project@83b5c4f JIRA: CPOUI5FOUNDATION-1174
Cherry-picked from: SAP/ui5-project@cb4e858 JIRA: CPOUI5FOUNDATION-1174
Cherry-picked from: SAP/ui5-cli@d29ead8 JIRA: CPOUI5FOUNDATION-1174
* Improve handling for concurrent resource access and modifications, especially when buffering streams. * Deprecate getStatInfo in favor of dedicated getSize, isDirectory, getLastModified methods. * Deprecate synchronous getStream in favor of getStreamAsync and modifyStream, allowing for atomic modification of resource content * Generate Resource hash using ssri
This allows asynchronous processes to finish as outlined in the Node.js documentation [1] When using the V8 inspector, this allows the debugger to gracefully disconnect when sending a SIGINT (e.g. CTRL+C) [1]: https://nodejs.org/api/process.html#processexitcode
getIntegrity tests still need to be updated
RandomByte
force-pushed
the
feat/incremental-build-2
branch
from
8bb2622 to
eb6f410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of RFC 0017 Incremental Build
This PR supersedes previous PoC: #1199
JIRA: CPOUI5FOUNDATION-1174