fix(pp2wap,clmpv): fill AORC NaN data-gaps in all stages that read ra…#13
Merged
Merged
Conversation
…w precip Extends the LMC in-domain NaN fill to the other stages that consume raw AORC precip, so corrupt mirror days (e.g. 1985-11-07, 2003-10-19, 2024-06-18) cannot void watershed data anywhere in the pipeline. Refactors the fill into a shared helper _fill_indomain_nan_gaps (majority-domain detection; off-domain NaN left untouched so the domain boundary is preserved) used by both run_pp2wap (per year, before PP2WAP) and run_lmc. Adds _fill_ref_nan_in_basin for run_clmpv's single grid-reference file (fills NaN inside the watershed polygon so a corrupt reference day cannot shrink the CLMPV mask). run_amc reads derived WAP, not raw AORC, so needs no change. Filling before PP2WAP also recovers whole years an all-NaN day would otherwise void: verified 2024 WAP finite values 0 -> 23,497,200 after fill + PP2WAP. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w precip
Extends the LMC in-domain NaN fill to the other stages that consume raw AORC precip, so corrupt mirror days (e.g. 1985-11-07, 2003-10-19, 2024-06-18) cannot void watershed data anywhere in the pipeline. Refactors the fill into a shared helper _fill_indomain_nan_gaps (majority-domain detection; off-domain NaN left untouched so the domain boundary is preserved) used by both run_pp2wap (per year, before PP2WAP) and run_lmc. Adds _fill_ref_nan_in_basin for run_clmpv's single grid-reference file (fills NaN inside the watershed polygon so a corrupt reference day cannot shrink the CLMPV mask). run_amc reads derived WAP, not raw AORC, so needs no change.
Filling before PP2WAP also recovers whole years an all-NaN day would otherwise void: verified 2024 WAP finite values 0 -> 23,497,200 after fill + PP2WAP.