Open
Conversation
SRS 회전, 월킥, 더블 버퍼링 렌더링, 레벨 시스템을 포함한 콘솔 테트리스를 외부 의존성 없이 순수 Kotlin으로 구현. CLAUDE.md와 AGENTS.md를 포함하여 CodeRabbit이 프로젝트 컨텍스트 없이 리뷰하는 baseline을 측정. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
기술적 의사결정 근거, 시행착오 이력, 세션별 작업 내역을 .claude/docs/PL-001-tetris/에 추가하여 CodeRabbit이 프로젝트 컨텍스트를 참조한 리뷰를 하는지 비교 측정. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
knowledge_base.filePatterns에 .claude/docs/**/*.md 글로브를 추가하여 브랜치별 계획 문서(tasks.md, findings.md, progress.md)를 자동 참조하도록 설정. path_instructions에 3-File Pattern 기반 리뷰 원칙을 범용으로 정의. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds a complete console Tetris implementation in Kotlin (Board, Piece, Game, Score, Input, Renderer, Main) plus project planning and workflow documentation (CLAUDE.md, README, AGENTS.md, .claude/docs/*, .coderabbit.yaml). Features SRS rotation with wall kicks, ANSI double-buffered rendering, and terminal raw-mode input handling. Changes
Sequence DiagramsequenceDiagram
participant Main
participant Game
participant Input
participant Board
participant Renderer
participant Score
Main->>Game: run()
activate Game
Game->>Renderer: renderInitial()
Renderer-->>Game: initial frame drawn
Game->>Input: input.start()
Input-->>Game: (daemon) queued Actions
loop Game loop (frame)
Game->>Input: poll() -> Action
alt Action != NONE
Game->>Board: isValidPosition / ghostY / lockPiece
Board-->>Game: validity / landingY / linesCleared
Game->>Score: addSoftDrop/addHardDrop/addLineClear
end
Game->>Game: rotate/move/spawn logic (SRS + kicks)
Game->>Renderer: render(board, currentPiece, nextPiece, score)
Renderer-->>Game: frame updated
Game->>Game: sleep(frameDelay)
end
Game->>Renderer: renderGameOver(score)
Game->>Input: input.stop()
deactivate Game
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (8)
20260218-3files/src/tetris/Input.kt (2)
47-49: Consider logging unexpected exceptions instead of silently swallowing.While ignoring
IOExceptionon stream close is reasonable, catching allExceptiontypes silently can hide unexpected errors during development.♻️ Proposed fix
- } catch (e: Exception) { - // 입력 스트림 종료 시 무시 + } catch (e: java.io.IOException) { + // 입력 스트림 종료 시 루프 종료 + break }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Input.kt` around lines 47 - 49, The current catch block in Input.kt that does "catch (e: Exception) { // 입력 스트림 종료 시 무시 }" swallows all exceptions; change it to specifically catch IOException for expected stream-close behavior (e.g., "catch (e: IOException) { /* ignore */ }") and add a separate catch for other exceptions that logs or surfaces them (e.g., "catch (e: Exception) { logger.error(\"Unexpected error in input loop\", e)" or at minimum call e.printStackTrace()) so unexpected errors are not silently ignored; update any relevant function or class in Input.kt where this try/catch appears.
86-88: Note:stop()won't immediately terminate the blocked reader thread.Since
System.in.read()is blocking, the thread will remain blocked until input arrives or the stream closes. As a daemon thread, this is acceptable for a game that exits the JVM, but be aware if reusing this class in other contexts.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Input.kt` around lines 86 - 88, The stop() method only flips the running flag but does not unblock the reader thread stuck on System.in.read(); update stop() to also interrupt and close the reader so it terminates promptly: store the reader thread (e.g., inputThread) when started, and in stop() call inputThread.interrupt() and attempt to close System.in (or the wrapped InputStream used by your reader) so the blocking read throws/returns; ensure the reader loop in the reading function checks Thread.currentThread().isInterrupted() and handles IOException from stream closure to exit cleanly.20260218-3files/CLAUDE.md (1)
28-34: Add language specifiers to code blocks for better rendering.Multiple code blocks are missing language specifiers, which can affect rendering and accessibility. Consider adding appropriate identifiers:
- Lines 28-34 and 40-46 (workflow diagrams): Add
textidentifier- Lines 87-92 and 145-151 (directory structures): Add
textorbashidentifier- Lines 315-320 (error protocol): Add
textidentifier📝 Proposed fixes for code block language specifiers
Lines 28-34:
-``` +```text /oh-my-claudecode:plan 호출Lines 40-46:
-``` +```text Phase 1: 계획 수립 및 검증 (4단계) ─── 계획을 세우고, 세 번 검토한다Lines 87-92:
-``` +```text 프로젝트루트/Lines 145-151:
-``` +```text .claude/docs/Lines 315-320:
-``` +```text ATTEMPT 1: 진단 및 수정 - 에러 분석, 근본 원인 파악, 대상 수정As per static analysis hints (markdownlint MD040 warnings).
Also applies to: 40-46, 87-92, 145-151, 315-320
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/CLAUDE.md` around lines 28 - 34, Update the fenced code blocks noted in the review so they include language specifiers (e.g., add "text" or "bash") to satisfy markdownlint MD040: add ```text before the workflow block containing "/oh-my-claudecode:plan 호출" and the "Phase 1: 계획 수립..." block, add ```text or ```bash before the directory examples "프로젝트루트/" and ".claude/docs/", and add ```text before the error protocol block starting with "ATTEMPT 1: 진단 및 수정"; ensure each corresponding closing ``` remains and that only the fence markers are changed so rendering and accessibility improve without altering content.20260218-3files/src/tetris/Renderer.kt (1)
139-141: EmptyrenderBorder()method could be removed.This method is a no-op since borders are drawn in
renderInitial(). Consider removing it to reduce confusion, or add a comment explaining why it exists (e.g., for API consistency).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Renderer.kt` around lines 139 - 141, The renderBorder() method is a no-op because borders are drawn in renderInitial(); either remove the renderBorder() function entirely to avoid confusion or keep it but add a clear comment explaining it's intentionally empty for API compatibility (e.g., "no-op: borders handled in renderInitial()") so other developers understand its presence; update references to renderBorder() if removed, or ensure its signature remains stable if kept for compatibility.20260218-3files/src/tetris/Main.kt (1)
31-39: Consider using ProcessBuilder for better error handling.
Runtime.exec()works butProcessBuilderprovides better error stream handling and is the modern approach.♻️ Optional ProcessBuilder alternative
private fun setRawMode() { ProcessBuilder("/bin/sh", "-c", "stty -icanon min 1 -echo < /dev/tty") .inheritIO() .start() .waitFor() } private fun restoreTerminal() { ProcessBuilder("/bin/sh", "-c", "stty sane < /dev/tty") .inheritIO() .start() .waitFor() }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Main.kt` around lines 31 - 39, The calls in setRawMode and restoreTerminal use Runtime.getRuntime().exec(...) which lacks convenient error/IO handling; replace them with ProcessBuilder for both setRawMode() and restoreTerminal(), build the process with the same command ("/bin/sh", "-c", "stty ... < /dev/tty"), start it, connect or inherit IO so stderr/stdout are visible (or capture and log the error stream), waitFor the process to complete and check its exit value, and throw or log a descriptive error including the process output if the exit code is non-zero to improve diagnostics.20260218-3files/src/tetris/Score.kt (1)
41-47: Consider validating non-negative row counts in drop methods.
addSoftDropandaddHardDropdon't validate thatrowsis non-negative. Negative values would incorrectly reduce the score.🛡️ Optional validation
fun addSoftDrop(rows: Int) { + if (rows <= 0) return score += rows } fun addHardDrop(rows: Int) { + if (rows <= 0) return score += rows * 2 }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Score.kt` around lines 41 - 47, addSoftDrop and addHardDrop don't validate that the rows parameter is non-negative, allowing negative values to decrease score; update both functions (addSoftDrop and addHardDrop) to check rows >= 0 and reject invalid input (e.g., throw IllegalArgumentException with a clear message) or clamp to 0 before updating the score variable so negative rows cannot reduce score. Ensure the validation occurs before modifying score and keep error text descriptive (mention function name and invalid rows).20260218-3files/src/tetris/Piece.kt (1)
59-64: Data class with mutable properties.
Pieceis adata classwithvarproperties (x,y,rotation). While functional, this can lead to unintended mutations. Thecopy()method at line 74 is redundant since data classes auto-generatecopy().Consider using
valproperties and relying on the auto-generatedcopy(x = newX, y = newY, rotation = newRotation)for immutable state transitions, which is more idiomatic Kotlin.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Piece.kt` around lines 59 - 64, The Piece data class currently declares mutable properties (var x, var y, var rotation) and also defines a redundant manual copy() — change these properties to immutable vals (val x, val y, val rotation) and remove the custom copy() implementation so callers use the data class's auto-generated copy(x = ..., y = ..., rotation = ...) for state transitions; update any call sites that relied on in-place mutation of Piece to instead reassign the Piece reference using piece.copy(...) (identify class Piece, its properties x/y/rotation and the custom copy() method to modify).20260218-3files/src/tetris/Game.kt (1)
15-17: Consider restricting visibility ofboardandscore.Exposing
boardandscoreas public properties allows external mutation of game state. If external read access is needed (e.g., for testing), consider exposing read-only views or making themprivatewith getters.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@20260218-3files/src/tetris/Game.kt` around lines 15 - 17, The Game class currently exposes mutable properties board and score publicly; make them private (e.g., private val board: Board, private val score: Score) and add controlled accessors as needed — either read-only getters (fun getBoard(): BoardView or val boardView: BoardView) or simple public getters that return immutable/read-only interfaces of Board and Score so external code cannot mutate internal state directly; update any callers to use the new getters or view types and adjust tests to depend on the read-only interfaces.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@20260218-3files/AGENTS.md`:
- Around line 17-29: Update the fenced code blocks in AGENTS.md that currently
lack a language tag by changing their opening fences from ``` to a labeled fence
(e.g., ```text) so markdownlint MD040 is satisfied; specifically add `text` (or
another appropriate language) to the ASCII diagram block (the box/arrow diagram)
and to the file-tree block (the src/ tetris listing) as well as the other
identified fenced block ranges (the ones flagged at 33-43 and 87) so each fenced
block begins with ```text.
In `@20260218-3files/src/tetris/Game.kt`:
- Around line 26-50: Wrap the main game logic in Game.run() with a try-finally
so renderer.cleanup() and input.stop() always run on exit or exception: after
calling input.start() and renderer.renderInitial(), put the game loop and
renderer.renderGameOver(score) inside a try block, and in the finally block call
renderer.cleanup() and input.stop(); ensure you reference the run() method,
renderer.cleanup(), input.stop(), and renderer.renderGameOver(score) when making
the change so the input thread is stopped and renderer resources are released
even if an exception occurs.
In `@20260218-3files/src/tetris/Input.kt`:
- Around line 33-34: When System.`in`.read() returns -1 (EOF) the current code
does "if (b == -1) continue" which spins; change the EOF handling in the input
loop (where System.`in`.read() and variable b are used) to break out of the loop
or set running = false and then break so the loop stops cleanly (update the loop
controlling variable named running and the place that reads b accordingly).
In `@20260218-3files/src/tetris/Renderer.kt`:
- Around line 17-19: Renderer's prevBuffer is initialized to -1 which collides
with GHOST_COLOR and prevents ghost cells from rendering on the first frame;
change the initial sentinel used for prevBuffer (in the Renderer class, the
prevBuffer property) to a value that can never be a valid color (e.g.,
Int.MIN_VALUE or a new constant like INITIAL_SENTINEL) and update any references
to GHOST_COLOR only if they currently rely on -1; ensure comparisons still use
frame[row][col] != prevBuffer[row][col] so the ghost will be drawn on the first
frame.
---
Nitpick comments:
In `@20260218-3files/CLAUDE.md`:
- Around line 28-34: Update the fenced code blocks noted in the review so they
include language specifiers (e.g., add "text" or "bash") to satisfy markdownlint
MD040: add ```text before the workflow block containing "/oh-my-claudecode:plan
호출" and the "Phase 1: 계획 수립..." block, add ```text or ```bash before the
directory examples "프로젝트루트/" and ".claude/docs/", and add ```text before the
error protocol block starting with "ATTEMPT 1: 진단 및 수정"; ensure each
corresponding closing ``` remains and that only the fence markers are changed so
rendering and accessibility improve without altering content.
In `@20260218-3files/src/tetris/Game.kt`:
- Around line 15-17: The Game class currently exposes mutable properties board
and score publicly; make them private (e.g., private val board: Board, private
val score: Score) and add controlled accessors as needed — either read-only
getters (fun getBoard(): BoardView or val boardView: BoardView) or simple public
getters that return immutable/read-only interfaces of Board and Score so
external code cannot mutate internal state directly; update any callers to use
the new getters or view types and adjust tests to depend on the read-only
interfaces.
In `@20260218-3files/src/tetris/Input.kt`:
- Around line 47-49: The current catch block in Input.kt that does "catch (e:
Exception) { // 입력 스트림 종료 시 무시 }" swallows all exceptions; change it to
specifically catch IOException for expected stream-close behavior (e.g., "catch
(e: IOException) { /* ignore */ }") and add a separate catch for other
exceptions that logs or surfaces them (e.g., "catch (e: Exception) {
logger.error(\"Unexpected error in input loop\", e)" or at minimum call
e.printStackTrace()) so unexpected errors are not silently ignored; update any
relevant function or class in Input.kt where this try/catch appears.
- Around line 86-88: The stop() method only flips the running flag but does not
unblock the reader thread stuck on System.in.read(); update stop() to also
interrupt and close the reader so it terminates promptly: store the reader
thread (e.g., inputThread) when started, and in stop() call
inputThread.interrupt() and attempt to close System.in (or the wrapped
InputStream used by your reader) so the blocking read throws/returns; ensure the
reader loop in the reading function checks
Thread.currentThread().isInterrupted() and handles IOException from stream
closure to exit cleanly.
In `@20260218-3files/src/tetris/Main.kt`:
- Around line 31-39: The calls in setRawMode and restoreTerminal use
Runtime.getRuntime().exec(...) which lacks convenient error/IO handling; replace
them with ProcessBuilder for both setRawMode() and restoreTerminal(), build the
process with the same command ("/bin/sh", "-c", "stty ... < /dev/tty"), start
it, connect or inherit IO so stderr/stdout are visible (or capture and log the
error stream), waitFor the process to complete and check its exit value, and
throw or log a descriptive error including the process output if the exit code
is non-zero to improve diagnostics.
In `@20260218-3files/src/tetris/Piece.kt`:
- Around line 59-64: The Piece data class currently declares mutable properties
(var x, var y, var rotation) and also defines a redundant manual copy() — change
these properties to immutable vals (val x, val y, val rotation) and remove the
custom copy() implementation so callers use the data class's auto-generated
copy(x = ..., y = ..., rotation = ...) for state transitions; update any call
sites that relied on in-place mutation of Piece to instead reassign the Piece
reference using piece.copy(...) (identify class Piece, its properties
x/y/rotation and the custom copy() method to modify).
In `@20260218-3files/src/tetris/Renderer.kt`:
- Around line 139-141: The renderBorder() method is a no-op because borders are
drawn in renderInitial(); either remove the renderBorder() function entirely to
avoid confusion or keep it but add a clear comment explaining it's intentionally
empty for API compatibility (e.g., "no-op: borders handled in renderInitial()")
so other developers understand its presence; update references to renderBorder()
if removed, or ensure its signature remains stable if kept for compatibility.
In `@20260218-3files/src/tetris/Score.kt`:
- Around line 41-47: addSoftDrop and addHardDrop don't validate that the rows
parameter is non-negative, allowing negative values to decrease score; update
both functions (addSoftDrop and addHardDrop) to check rows >= 0 and reject
invalid input (e.g., throw IllegalArgumentException with a clear message) or
clamp to 0 before updating the score variable so negative rows cannot reduce
score. Ensure the validation occurs before modifying score and keep error text
descriptive (mention function name and invalid rows).
Comment on lines
+17
to
+29
| ``` | ||
| ┌──────────┐ ┌──────────┐ ┌──────────┐ | ||
| │ Input │────▶│ Game │────▶│ Renderer │ | ||
| │(키보드) │ │ (루프) │ │(콘솔출력) │ | ||
| └──────────┘ └──────────┘ └──────────┘ | ||
| │ | ||
| ┌───────┼───────┐ | ||
| ▼ ▼ ▼ | ||
| ┌────────┐ ┌─────┐ ┌───────┐ | ||
| │ Board │ │Piece│ │ Score │ | ||
| │(10x20) │ │(SRS)│ │(레벨) │ | ||
| └────────┘ └─────┘ └───────┘ | ||
| ``` |
There was a problem hiding this comment.
Add language identifiers to fenced blocks (MD040).
Markdownlint flags missing language identifiers for fenced code blocks; specify a language like text to satisfy lint and improve tooling.
🔧 Proposed fix
-```
+```text
┌──────────┐ ┌──────────┐ ┌──────────┐
│ Input │────▶│ Game │────▶│ Renderer │
│(키보드) │ │ (루프) │ │(콘솔출력) │
└──────────┘ └──────────┘ └──────────┘
│
┌───────┼───────┐
▼ ▼ ▼
┌────────┐ ┌─────┐ ┌───────┐
│ Board │ │Piece│ │ Score │
│(10x20) │ │(SRS)│ │(레벨) │
└────────┘ └─────┘ └───────┘- +text
src/
└── tetris/
├── Main.kt # 진입점, 터미널 설정, 게임 시작
├── Game.kt # 게임 루프, 상태 관리, 타이머
├── Board.kt # 10x20 그리드, 충돌 감지, 라인 클리어
├── Piece.kt # 7종 테트로미노 정의, SRS 회전, 월킥
├── Input.kt # 터미널 raw 모드, 키 입력 처리
├── Renderer.kt # ANSI escape code 렌더링, 더블 버퍼링
└── Score.kt # 점수 계산, 레벨 시스템
Also applies to: 33-43, 87-87
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 28-28: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@20260218-3files/AGENTS.md` around lines 17 - 29, Update the fenced code
blocks in AGENTS.md that currently lack a language tag by changing their opening
fences from ``` to a labeled fence (e.g., ```text) so markdownlint MD040 is
satisfied; specifically add `text` (or another appropriate language) to the
ASCII diagram block (the box/arrow diagram) and to the file-tree block (the src/
tetris listing) as well as the other identified fenced block ranges (the ones
flagged at 33-43 and 87) so each fenced block begins with ```text.
Comment on lines
+26
to
+50
| fun run() { | ||
| input.start() | ||
| renderer.renderInitial() | ||
|
|
||
| while (state == GameState.PLAYING) { | ||
| val action = input.poll() | ||
| handleAction(action) | ||
|
|
||
| // 자동 낙하 | ||
| val now = System.currentTimeMillis() | ||
| if (now - lastDropTime >= score.dropInterval) { | ||
| if (!moveDown()) { | ||
| lockAndSpawn() | ||
| } | ||
| lastDropTime = now | ||
| } | ||
|
|
||
| renderer.render(board, currentPiece, nextPiece, score) | ||
|
|
||
| Thread.sleep(FRAME_DELAY_MS) | ||
| } | ||
|
|
||
| renderer.renderGameOver(score) | ||
| input.stop() | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check if Renderer class has a cleanup method
fd -t f '\.(kt|java)$' | xargs grep -l 'class Renderer' | head -5Repository: USKTEA/coding-life
Length of output: 394
🏁 Script executed:
# Also search for any cleanup methods in the codebase
rg 'fun cleanup|def cleanup' --type kt --type javaRepository: USKTEA/coding-life
Length of output: 88
🏁 Script executed:
# Check Input class for cleanup/stop methods
fd -t f '\.(kt|java)$' | xargs grep -l 'class Input\|interface Input' | head -5Repository: USKTEA/coding-life
Length of output: 391
🏁 Script executed:
cat -n 20260218-3files/src/tetris/Renderer.ktRepository: USKTEA/coding-life
Length of output: 6670
🏁 Script executed:
cat -n 20260218-3files/src/tetris/Input.ktRepository: USKTEA/coding-life
Length of output: 3039
🏁 Script executed:
cat -n 20260218-3files/src/tetris/Game.ktRepository: USKTEA/coding-life
Length of output: 5454
Add try-finally block to ensure renderer cleanup and input stop on any exception.
The renderer.cleanup() method exists but is not called in the game loop. Additionally, if an exception occurs during gameplay, input.stop() won't be executed, leaving the input thread running unnecessarily until JVM exit (though it is a daemon thread). Wrap the game logic in try-finally to ensure both cleanup operations complete regardless of how the loop exits.
🛡️ Proposed fix
fun run() {
input.start()
- renderer.renderInitial()
-
- while (state == GameState.PLAYING) {
- val action = input.poll()
- handleAction(action)
-
- // 자동 낙하
- val now = System.currentTimeMillis()
- if (now - lastDropTime >= score.dropInterval) {
- if (!moveDown()) {
- lockAndSpawn()
+ try {
+ renderer.renderInitial()
+
+ while (state == GameState.PLAYING) {
+ val action = input.poll()
+ handleAction(action)
+
+ // 자동 낙하
+ val now = System.currentTimeMillis()
+ if (now - lastDropTime >= score.dropInterval) {
+ if (!moveDown()) {
+ lockAndSpawn()
+ }
+ lastDropTime = now
}
- lastDropTime = now
- }
- renderer.render(board, currentPiece, nextPiece, score)
+ renderer.render(board, currentPiece, nextPiece, score)
- Thread.sleep(FRAME_DELAY_MS)
- }
+ Thread.sleep(FRAME_DELAY_MS)
+ }
- renderer.renderGameOver(score)
- input.stop()
+ renderer.renderGameOver(score)
+ } finally {
+ input.stop()
+ renderer.cleanup()
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| fun run() { | |
| input.start() | |
| renderer.renderInitial() | |
| while (state == GameState.PLAYING) { | |
| val action = input.poll() | |
| handleAction(action) | |
| // 자동 낙하 | |
| val now = System.currentTimeMillis() | |
| if (now - lastDropTime >= score.dropInterval) { | |
| if (!moveDown()) { | |
| lockAndSpawn() | |
| } | |
| lastDropTime = now | |
| } | |
| renderer.render(board, currentPiece, nextPiece, score) | |
| Thread.sleep(FRAME_DELAY_MS) | |
| } | |
| renderer.renderGameOver(score) | |
| input.stop() | |
| } | |
| fun run() { | |
| input.start() | |
| try { | |
| renderer.renderInitial() | |
| while (state == GameState.PLAYING) { | |
| val action = input.poll() | |
| handleAction(action) | |
| // 자동 낙하 | |
| val now = System.currentTimeMillis() | |
| if (now - lastDropTime >= score.dropInterval) { | |
| if (!moveDown()) { | |
| lockAndSpawn() | |
| } | |
| lastDropTime = now | |
| } | |
| renderer.render(board, currentPiece, nextPiece, score) | |
| Thread.sleep(FRAME_DELAY_MS) | |
| } | |
| renderer.renderGameOver(score) | |
| } finally { | |
| input.stop() | |
| renderer.cleanup() | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@20260218-3files/src/tetris/Game.kt` around lines 26 - 50, Wrap the main game
logic in Game.run() with a try-finally so renderer.cleanup() and input.stop()
always run on exit or exception: after calling input.start() and
renderer.renderInitial(), put the game loop and renderer.renderGameOver(score)
inside a try block, and in the finally block call renderer.cleanup() and
input.stop(); ensure you reference the run() method, renderer.cleanup(),
input.stop(), and renderer.renderGameOver(score) when making the change so the
input thread is stopped and renderer resources are released even if an exception
occurs.
Comment on lines
+33
to
+34
| val b = System.`in`.read() | ||
| if (b == -1) continue |
There was a problem hiding this comment.
EOF handling causes CPU spin loop.
When read() returns -1 (end of stream), continuing the loop will cause repeated -1 returns, creating a busy-wait that wastes CPU cycles. Should break out of the loop or set running = false.
🐛 Proposed fix
val b = System.`in`.read()
- if (b == -1) continue
+ if (b == -1) break📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| val b = System.`in`.read() | |
| if (b == -1) continue | |
| val b = System.`in`.read() | |
| if (b == -1) break |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@20260218-3files/src/tetris/Input.kt` around lines 33 - 34, When
System.`in`.read() returns -1 (EOF) the current code does "if (b == -1)
continue" which spins; change the EOF handling in the input loop (where
System.`in`.read() and variable b are used) to break out of the loop or set
running = false and then break so the loop stops cleanly (update the loop
controlling variable named running and the place that reads b accordingly).
Comment on lines
+17
to
+19
| class Renderer { | ||
| private val prevBuffer = Array(Board.HEIGHT) { IntArray(Board.WIDTH) { -1 } } | ||
| private val sb = StringBuilder(4096) |
There was a problem hiding this comment.
Potential first-frame ghost rendering issue.
prevBuffer is initialized with -1, which equals GHOST_COLOR. On the first frame, if a ghost piece occupies a cell, frame[row][col] will be -1 and prevBuffer[row][col] is also -1, so the comparison frame[row][col] != prevBuffer[row][col] will be false, and the ghost won't render.
Consider using a different sentinel value for the initial buffer state:
🐛 Proposed fix
class Renderer {
- private val prevBuffer = Array(Board.HEIGHT) { IntArray(Board.WIDTH) { -1 } }
+ private val prevBuffer = Array(Board.HEIGHT) { IntArray(Board.WIDTH) { Int.MIN_VALUE } }
private val sb = StringBuilder(4096)And update GHOST_COLOR if needed:
companion object {
- private const val GHOST_COLOR = -1
+ private const val GHOST_COLOR = -1 // OK since prevBuffer uses Int.MIN_VALUE📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| class Renderer { | |
| private val prevBuffer = Array(Board.HEIGHT) { IntArray(Board.WIDTH) { -1 } } | |
| private val sb = StringBuilder(4096) | |
| class Renderer { | |
| private val prevBuffer = Array(Board.HEIGHT) { IntArray(Board.WIDTH) { Int.MIN_VALUE } } | |
| private val sb = StringBuilder(4096) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@20260218-3files/src/tetris/Renderer.kt` around lines 17 - 19, Renderer's
prevBuffer is initialized to -1 which collides with GHOST_COLOR and prevents
ghost cells from rendering on the first frame; change the initial sentinel used
for prevBuffer (in the Renderer class, the prevBuffer property) to a value that
can never be a valid color (e.g., Int.MIN_VALUE or a new constant like
INITIAL_SENTINEL) and update any references to GHOST_COLOR only if they
currently rely on -1; ensure comparisons still use frame[row][col] !=
prevBuffer[row][col] so the ghost will be drawn on the first frame.
knowledge_base.code_guidelines는 default branch(main) 파일만 인덱싱하므로 feature branch의 3-file 문서를 참조하지 못하는 문제를 해결한다. 변경사항: - tone_instructions에 한국어 리뷰 명시적 강제 - path_instructions에 tasks.md/findings.md 핵심 내용 직접 임베딩 - 의도적 기술 결정, 제약조건, 해결 완료 이슈를 인라인으로 제공 - knowledge_base는 main 머지 후 자동 인덱싱용으로 유지 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: CodeRabbit 한국어 리뷰 및 3-File Pattern 컨텍스트 임베딩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.coderabbit.yaml추가:knowledge_base.filePatterns에.claude/docs/**/*.md글로브를 설정하여 브랜치별 3-File Pattern 문서를 자동 참조path_instructions에 3-File Pattern 기반 범용 리뷰 원칙 정의Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation