fix: sanitize subprocess call in app.py - #5
Open
anupamme wants to merge 1 commit into
Open
Conversation
The application uses subprocess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
WAVE2SCORE/app.py.Vulnerability
V-001WAVE2SCORE/app.py:65Description: The application uses subprocess.run to execute external commands with user-controlled input from uploaded files. While using an array format reduces risk, the input_path variable contains user-controlled data that could include shell metacharacters.
Evidence
Exploitation scenario: Attacker uploads a .wav file with a filename containing shell metacharacters (e.g., 'input.wav; cat /etc/passwd').
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This main application appears to be publicly accessible.
Changes
WAVE2SCORE/app.pyVerification
Automated security fix by OrbisAI Security