feat(ci): wire central ci-workflows@v1 non-NMS caller - #1
Conversation
- Create .github/workflows/maven-ci.yml with reusable workflow - Uses UltiKits/ci-workflows/.github/workflows/maven-ci.yml@v1 - needs-nms: false (pure API module, no NMS)
📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow file ( ChangesCI Workflow Setup
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/maven-ci.yml (1)
10-11: 🔒 Security & Privacy | 🔵 Trivial | ⚖️ Poor tradeoffFloating
@v1tag is a conscious tradeoff — consider org-wide SHA pinning policy.Referencing
UltiKits/ci-workflows/...@v1means any retag or compromise ofv1upstream immediately affects this workflow's execution. The inline comment already acknowledges this tradeoff in favor of auto-receiving re-pins, which is reasonable for an internal, trusted org repo, but for stricter supply-chain hygiene consider pinning to a full commit SHA at least for release/protected branches.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/maven-ci.yml around lines 10 - 11, The reusable workflow reference in the maven CI config is using a floating `@v1` tag, which should be aligned with your supply-chain policy. Update the uses reference for UltiKits/ci-workflows/.github/workflows/maven-ci.yml to a full commit SHA for release/protected branches, or otherwise make the pinning strategy explicit and consistent with the org-wide policy noted in the inline comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/maven-ci.yml:
- Around line 10-11: The reusable workflow reference in the maven CI config is
using a floating `@v1` tag, which should be aligned with your supply-chain policy.
Update the uses reference for
UltiKits/ci-workflows/.github/workflows/maven-ci.yml to a full commit SHA for
release/protected branches, or otherwise make the pinning strategy explicit and
consistent with the org-wide policy noted in the inline comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0f2b14b9-d380-4f7b-a044-8e2d434cc71a
📒 Files selected for processing (1)
.github/workflows/maven-ci.yml
Summary
Wire UltiEconomy to the shared ci-workflows repository.
Changes
.github/workflows/maven-ci.ymlwith exact non-NMS caller (sha256:a6e6a2fcc8...)UltiKits/ci-workflows/.github/workflows/maven-ci.yml@v1needs-nms: false(pure API module)Verification
mvn -B test(322 tests pass),mvn -B package(success)a6e6a2fcc83bc5a28b749ee0300f05d9bcd729852a1a22a96c443590ff16fe2aScope
Single file change. No POM or source modifications.
Summary by CodeRabbit