Skip to content

chore: remove stale .github/copilot-instructions.md - #175

Merged
wisdommen merged 1 commit into
alphafrom
chore/remove-stale-copilot-instructions
Aug 10, 2026
Merged

chore: remove stale .github/copilot-instructions.md#175
wisdommen merged 1 commit into
alphafrom
chore/remove-stale-copilot-instructions

Conversation

@wisdommen

Copy link
Copy Markdown
Contributor

What

Deletes .github/copilot-instructions.md.

Why

Last touched 2026-02-22. It had drifted far enough to be actively misleading — two of its examples do not compile against the current API:

It teaches Reality
@ConfigEntity(path = "config/myconfig.yml") The annotation only declares String value() (annotations/ConfigEntity.java:21). No path attribute → compile error.
class MyEntity extends AbstractDataEntity + getDataOperator(MyEntity.class) AbstractDataEntity is @Deprecated(since = "6.2.0", forRemoval = true) (:26); getDataOperator is bounded <T extends BaseDataEntity<String>> (UltiToolsPlugin.java:370). Not a warning — a compile error.

Three further factual errors:

  • Calls the project a "Minecraft Spigot plugin framework" — it is Paper-only; Adventure Component is used throughout and spigot-api is commented out in pom.xml.
  • "Dependencies are copied to target/UltiTools/lib/ on package" — replaced by maven-shade; UltiTools/lib has zero occurrences in pom.xml.
  • Javadoc output given as target/apidocs/ — actually target/site/apidocs/.

Why delete rather than rewrite

PROJECT.md is the maintained control card for coding agents and already covers the same ground correctly. Keeping a second, unowned copy is what produced this drift. Nothing in the repository references the removed file (verified with a case-insensitive search across all tracked paths).

Risk

None to the build. This file is documentation only and is not read by any workflow, plugin, or test.

🤖 Generated with Claude Code

https://claude.ai/code/session_01J9hmZrywjj8deHYraePCkZ

The file was last touched 2026-02-22 and had drifted far enough to be
actively misleading. Two of its examples do not compile against the
current API:

- `@ConfigEntity(path = "...")` — the annotation only declares
  `String value()`; there is no `path` attribute.
- `class MyEntity extends AbstractDataEntity` combined with
  `getDataOperator(MyEntity.class)` — `AbstractDataEntity` is
  `@Deprecated(since = "6.2.0", forRemoval = true)` and does not satisfy
  the `<T extends BaseDataEntity<String>>` bound on `getDataOperator`.

Three further claims are wrong: it calls the project a "Spigot plugin
framework" (Paper-only; Adventure Component is used throughout), states
that dependencies are copied to `target/UltiTools/lib/` (replaced by
maven-shade), and points javadoc output at `target/apidocs/` instead of
`target/site/apidocs/`.

PROJECT.md is the maintained control card for coding agents and already
covers the same ground correctly, so this file is removed rather than
rewritten. Nothing in the repository references it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J9hmZrywjj8deHYraePCkZ
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e62e321f-fb80-4a90-8114-593e0bd86e09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Aug 10, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bf40c0b) 10908 7221 66.20%
Head commit (82b852b) 10908 (+0) 7221 (+0) 66.20% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#175) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@wisdommen
wisdommen merged commit 9b0a961 into alpha Aug 10, 2026
10 checks passed
@wisdommen
wisdommen deleted the chore/remove-stale-copilot-instructions branch August 10, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant