Skip to content

Russian translation#6

Open
userwindows10mobile wants to merge 5 commits into
UnicordDev:masterfrom
userwindows10mobile:master
Open

Russian translation#6
userwindows10mobile wants to merge 5 commits into
UnicordDev:masterfrom
userwindows10mobile:master

Conversation

@userwindows10mobile

Copy link
Copy Markdown

Russian translation

@er2off er2off left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have some small comments about some translation strings.

Comment on lines +124 to +129
<data name="FollowersRun.Text" xml:space="preserve">
<value>Следователи</value>
</data>
<data name="FollowingRun.Text" xml:space="preserve">
<value>Следователь</value>
</data>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Подписчики" and "Подписок"? (and yeah, following here is count, not action, wam, add context comment about this)

@er2off er2off Nov 23, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, in Russian these words can be changed with numbers (plurals), like
1, 101 подписчик/подписка
2,3,4, 103 (and other) подписчика/подписки
5 and other подписчиков/подписок

Comment thread UniSky/Resources/ru-RU/Resources.resw Outdated
<value>Посты</value>
</data>
<data name="FeedReplies" xml:space="preserve">
<value>Посты и Ответы</value>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "Ответы" is from capital letter? Lower-case it here or upper-case in other file.

Comment thread UniSky/Resources/ru-RU/Resources.resw Outdated
<value>Лайк</value>
</data>
<data name="ReplyingToRun.Text" xml:space="preserve">
<value>Отвечаете на</value>

@er2off er2off Nov 23, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without "на", that's like "Отвечает @username"

<value>Твиты и ответы</value>
</data>
<data name="RetweetedByRun.Text" xml:space="preserve">
<value>Ретвитнуто </value>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space at the end here.

@WamWooWam

Copy link
Copy Markdown
Contributor

Hi, thanks so much! If you don't mind I'm gonna put this on hold until I've made sure all strings are localisable, which should be in the next few days

@bingchris

bingchris commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Hi, thanks so much! If you don't mind I'm gonna put this on hold until I've made sure all strings are localisable, which should be in the next few days

Hello!
Once you finish that, I can help (or just flat-out make) a polish translation.
Edit: just did, if wam accepts this pr, someone remind me on the discord server to make a pull request, my username is wpeutil

@userwindows10mobile

Copy link
Copy Markdown
Author

i make changes . This is final

@WamWooWam

Copy link
Copy Markdown
Contributor

Hi there! @danil2201 @tarvey @er2off I've finally done that pass I promised to do, and now all strings in the app are localisable, so please take a look at this again if you get the chance! Thanks again :)

@bingchris

Copy link
Copy Markdown
Contributor

once this gets accepted, please accept #23

@bingchris

Copy link
Copy Markdown
Contributor

any update on this? also please edit the csproj because i forgot to edit it too (#25)

@WamWooWam

Copy link
Copy Markdown
Contributor

Any chance this can get rebased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants