Skip to content

build: make CMake target linkage compatible with Humble #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvorak0 wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

build: make CMake target linkage compatible with Humble #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1f54d
build: make CMake target linkage compatible with Humble
dvorak0 Apr 15, 2026
d4c2362
build: make input_aligner Time::max compatible with Humble
dvorak0 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ endif()
target_include_directories(${PROJECT_NAME} PUBLIC
"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
"$<INSTALL_INTERFACE:include/${PROJECT_NAME}>")
target_link_libraries(${PROJECT_NAME} PUBLIC
rclcpp::rclcpp
rcutils::rcutils
std_msgs::std_msgs
ament_target_dependencies(${PROJECT_NAME}
rclcpp
rcutils
std_msgs
)

install(
Expand Down Expand Up @@ -88,8 +88,11 @@ if(BUILD_TESTING)

ament_add_gtest(${PROJECT_NAME}-test_subscriber test/test_subscriber.cpp)
if(TARGET ${PROJECT_NAME}-test_subscriber)
target_link_libraries(${PROJECT_NAME}-test_subscriber ${PROJECT_NAME} rclcpp::rclcpp
rclcpp_lifecycle::rclcpp_lifecycle sensor_msgs::sensor_msgs)
target_link_libraries(${PROJECT_NAME}-test_subscriber ${PROJECT_NAME})
ament_target_dependencies(${PROJECT_NAME}-test_subscriber
rclcpp
rclcpp_lifecycle
sensor_msgs)
endif()

ament_add_gtest(${PROJECT_NAME}-test_synchronizer test/test_synchronizer.cpp)
Expand Down Expand Up @@ -124,12 +127,18 @@ if(BUILD_TESTING)

ament_add_gtest(${PROJECT_NAME}-test_fuzz test/test_fuzz.cpp SKIP_TEST)
if(TARGET ${PROJECT_NAME}-test_fuzz)
target_link_libraries(${PROJECT_NAME}-test_fuzz ${PROJECT_NAME} rclcpp::rclcpp sensor_msgs::sensor_msgs)
target_link_libraries(${PROJECT_NAME}-test_fuzz ${PROJECT_NAME})
ament_target_dependencies(${PROJECT_NAME}-test_fuzz
rclcpp
sensor_msgs)
endif()

ament_add_gtest(${PROJECT_NAME}-test_message_traits test/test_message_traits.cpp)
if(TARGET ${PROJECT_NAME}-test_message_traits)
target_link_libraries(${PROJECT_NAME}-test_message_traits ${PROJECT_NAME} rclcpp::rclcpp std_msgs::std_msgs)
target_link_libraries(${PROJECT_NAME}-test_message_traits ${PROJECT_NAME})
ament_target_dependencies(${PROJECT_NAME}-test_message_traits
rclcpp
std_msgs)
endif()

ament_add_gtest(${PROJECT_NAME}-test_input_aligner test/test_input_aligner.cpp)
Expand Down
4 changes: 2 additions & 2 deletions include/message_filters/input_aligner.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ class InputAligner : public noncopyable
{
public:
EventQueue()
: next_ts_(rclcpp::Time::max(RCL_ROS_TIME)), period_(0, 0),
: next_ts_(rclcpp::Time::max()), period_(0, 0),
active_(false), msgs_processed_(0), msgs_dropped_(0) {}

rclcpp::Time firstTimeStamp()
Expand All @@ -273,7 +273,7 @@ class InputAligner : public noncopyable
} else if (active_) {
return next_ts_;
}
return rclcpp::Time::max(RCL_ROS_TIME);
return rclcpp::Time::max();
}

void popFirst()
Expand Down