Skip to content

docs: note NFT position fee rounding#448

Open
leno23 wants to merge 1 commit into
Uniswap:mainfrom
leno23:docs/nft-fee-rounding-note
Open

docs: note NFT position fee rounding#448
leno23 wants to merge 1 commit into
Uniswap:mainfrom
leno23:docs/nft-fee-rounding-note

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 18, 2026

Summary

  • Document the expected integer-rounding behavior in INonfungiblePositionManager fee accounting.
  • Note that position updates can round down by less than 1 wei per token and that aggregate rounding loss may grow as a position is updated.

Closes #5
References Uniswap/v3-core#424

Test Plan

  • npx --yes --package prettier@2.0.5 --package prettier-plugin-solidity@1.0.0-alpha.59 prettier --check contracts/interfaces/INonfungiblePositionManager.sol
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accounting in NonfungiblePositionManager can bleed <1 wei of fees on every action

1 participant