Skip to content

fix(OracleLibrary): add missing @return for liquidity in getBlockStartingTickAndLiquidity NatSpec #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xAxiom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(OracleLibrary): add missing @return for liquidity in getBlockStartingTickAndLiquidity NatSpec #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/libraries/OracleLibrary.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ library OracleLibrary {
secondsAgo = uint32(block.timestamp) - observationTimestamp;
}

/// @notice Given a pool, it returns the tick value as of the start of the current block
/// @notice Given a pool, it returns the tick value and liquidity as of the start of the current block
/// @param pool Address of Uniswap V3 pool
/// @return The tick that the pool was in at the start of the current block
/// @return The liquidity of the pool as of the start of the current block
function getBlockStartingTickAndLiquidity(address pool) internal view returns (int24, uint128) {
(, int24 tick, uint16 observationIndex, uint16 observationCardinality, , , ) = IUniswapV3Pool(pool).slot0();

Expand Down