Skip to content

FIX: Implement caching for InputControlPath display name #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josepmariapujol-unity wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −3
Open

FIX: Implement caching for InputControlPath display name #2344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b38eb1
Fixing todo, caching to reduce GC in InputControlPath
josepmariapujol-unity Feb 12, 2026
8086d03
Fix display name in dropdown button for control picker
josepmariapujol-unity Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ however, it has to be formatted properly to pass verification tests.

### Fixed

- Fixed caching for InputControlPath display name.
- Fixed the `Auto-Save` toggle button with some extra pixels to align the text in the window better.
- Align title font size with toolbar style in `Input Action` window.
- Updated Action Properties headers to use colors consistent with GameObject component headers.
Expand Down
13 changes: 10 additions & 3 deletions Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@
return;
}

////TODO: this should be cached; generates needless GC churn
var displayName = InputControlPath.ToHumanReadableString(path);
// Cache the display name per path value and only recompute when the string actually changes.
if (!string.Equals(path, m_CachedPath, StringComparison.Ordinal))
{
m_CachedPath = path;
m_CachedDisplayName = InputControlPath.ToHumanReadableString(path);
}

Check warning on line 131 in Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs#L127-L131 

Added lines #L127 - L131 were not covered by tests

// Either show dropdown control that opens path picker or show path directly as
// text, if manual path editing is toggled on.
Expand All @@ -146,7 +150,7 @@
else
{
// Dropdown that shows binding text and allows opening control picker.
if (EditorGUI.DropdownButton(bindingTextRect, new GUIContent(displayName), FocusType.Keyboard))
if (EditorGUI.DropdownButton(bindingTextRect, new GUIContent(m_CachedDisplayName), FocusType.Keyboard))

Check warning on line 153 in Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs#L153 

Added line #L153 was not covered by tests
{
SetExpectedControlLayoutFromAttribute(serializedProperty);
////TODO: for bindings that are part of composites, use the layout information from the [InputControl] attribute on the field
Expand Down Expand Up @@ -209,6 +213,9 @@
private string m_ExpectedControlLayout;
private string[] m_ControlPathsToMatch;

private string m_CachedPath;
private string m_CachedDisplayName;

private InputControlPickerDropdown m_PickerDropdown;
private readonly InputControlPickerState m_PickerState;

Expand Down