feat(security): hash API keys, lock down audit logs, enforce route ownership - #397
Open
MatanOga01 wants to merge 1 commit into
Open
feat(security): hash API keys, lock down audit logs, enforce route ownership#397MatanOga01 wants to merge 1 commit into
MatanOga01 wants to merge 1 commit into
Conversation
…nership - API keys: persist only SHA-256 hashes, return the raw secret once at creation, support rotation/revocation, constant-time verification and endpoint scope enforcement (UnityChainxx#252) - Audit logs: admin-only reads and CSV export, retention purge, no public mutation paths (UnityChainxx#249) - Ownership guard on user-ID routes: callers may only access their own data unless they hold an explicit admin role (UnityChainxx#266) - Onchain: document storage versioning/migration strategy and add compatibility tests for legacy state (UnityChainxx#269) 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@MatanOga01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the Stellar Wave issues assigned to MatanOga01.
Changes
API key hashing and rotation (#252)
POST /api-keys/rotate/:keyendpoint; revocation and expiry still enforced.Audit-log tamper and access controls (#249)
JwtAuthGuard+RolesGuard), so ordinary users cannot read or modify records.GET /admin/audit-logs/export(CSV) andDELETE /admin/audit-logs/older-than/:days(retention purge) endpoints.Authorization on user-ID routes (#266)
@Ownership()decorator + globalOwnershipGuardenforce that callers can only access their own data, unless they carry an explicit admin role.userId.Contract storage versioning (#269)
onchain/docs/storage-versioning.mddefining the migration strategy for storage keys and serialized types.Questionreadability,LevelProgressround-trip, and stableLevelsdiscriminants.Tests
Closes #249
Closes #252
Closes #266
Closes #269