fix(onchain): structured & safe NFT badge mint failures - #402
Open
temiport25 wants to merge 1 commit into
Open
Conversation
…te safe
Resolve the configured admin before writing any badge state in the NFT
contract's mint_level_badge. If the NFT contract was never initialized
this now surfaces a structured NotInitialized error instead of an opaque
expect("admin not set") panic, and guarantees the badge/badge_data
writes can never be left as a partial state change on a failed mint.
- add NotInitialized error variant to StellarHuntsNft
- read admin up front in mint_level_badge before any storage write
- fix pre-existing broken test_double_mint_rejected (undefined client/long_uri)
- add test_mint_uninitialized_is_structured_and_leaves_no_partial_state
- drop unused receiver imports
Closes UnityChainxx#291
|
@temiport25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291