Fix amberly-d (#283 #284 #287 #290) - #418
Merged
dzekojohn4 merged 4 commits intoAug 31, 2026
Merged
Conversation
… wallet lifecycle, pagination a11y, responsive, CI gating Backend (issues UnityChainxx#283 UnityChainxx#284 UnityChainxx#287): - Wallet signature replay protection: challenge + ed25519 verify + consumed nonce tracking - JWT family-based reuse detection, rotation and revocation on refresh - Consolidate duplicate User entities onto the canonical auth User; remove dead entities Frontend (issues UnityChainxx#290 UnityChainxx#309 UnityChainxx#314): - Wallet connection lifecycle hook (extension absence, rejections, account/network changes, unsupported network, disconnect, stale session revalidation) - Pagination and infinite-scroll accessibility (nav landmark, aria-current, aria-live) - Responsive fixes for cards, dialogs and admin tables - Fix duplicate paths in frontend tsconfig to unblock vitest CI (issues UnityChainxx#311 UnityChainxx#321): - Require frontend lint/build and gate onchain/backend/frontend jobs via changed paths
amberly-d
changed the title
|
@amberly-d Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
dzekojohn4
approved these changes
Aug 31, 2026
dzekojohn4
left a comment
dzekojohn4
left a comment
Contributor
There was a problem hiding this comment.
Looks good, merging this in.
…erub-issues # Conflicts: # backend/src/app.module.ts # backend/src/user/entities/user.entity.ts
dzekojohn4
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes amberly-d issues closes #283, closes #284, closes #287, closes #290 , closes #309, closes #311, closes #314, closes #321.
Backend
Userentities into the canonicalauthUser; removed dead/stub entities (wallet/wallet.entity.ts,user-inventory/entities/user.ts,user/entities/user.entity.ts,user-inventory/entities/user-inventory.entity.ts).Frontend
useWalletConnectionhook handling extension absence, rejected/cancelled requests, account and network change detection, unsupported-network handling, disconnect, and stale-session revalidation; wired intousePuzzleContractandPuzzleComponent.navlandmark +aria-current/aria-disabledon pagination (Pagination, ReviewTable) andfeed/aria-livestatus region onNftGalleryVirtualized.CI
continue-on-error);npm auditkept as advisory due to a required Next.js major upgrade.dorny/paths-filtermatrix gates onchain/backend/frontend jobs to their own changed paths.Verification