fix: validate payment handler structure from profile instead of hardcoded list#33
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sbeashwar
force-pushed
the
pr2-handler-validation
branch
from
9437117 to
4e07e22
Compare
sbeashwar
force-pushed
the
pr2-handler-validation
branch
4 times, most recently
from
ad6639e to
f5f1357
Compare
|
@cusell-google gentle ping - this is a small, focused change ready for review when you have time. |
cusell-google
left a comment
cusell-google
left a comment
There was a problem hiding this comment.
Thanks @sbeashwar for the recent PRs and improvements!
…oded list Replace hardcoded expected handler IDs (google_pay, mock_payment_handler, shop_pay) with structural validation that: - Discovers handlers from the business profile dynamically - Validates required fields (id, version) are present - Validates handler group names follow reverse-DNS convention - Works against any UCP merchant, not just the Flower Shop This makes the protocol conformance tests server-agnostic. Addresses Universal-Commerce-Protocol#13
sbeashwar
force-pushed
the
pr2-handler-validation
branch
from
f5f1357 to
4c32e19
Compare
|
@archrao friendly bump when you have a moment |
|
@cusell-google quick procedural question - what's the typical path to get a second reviewer for PRs in this repo? |
|
@cusell-google @archrao looks like the workflow needs maintainer approval to run for first-time contributors - whenever either of you has a moment, could you click "Approve and run" so we can see CI green? |
cusell-google
merged commit 52e026a
into
Universal-Commerce-Protocol:main
3 participants
Description
Replaces hardcoded expected handler IDs (
google_pay,mock_payment_handler,shop_pay) inprotocol_test.pywith structural validation that discovers handlers from the business profile.The current test assumes the Flower Shop's specific handlers are present, which means any non-Flower-Shop merchant fails the protocol conformance test. This change makes the test server-agnostic.
Changes
id,version) are present on each handlerDepends on
Type of change
Checklist