Skip to content

chore: Add precommit checks for JSON schema.#389

Open
sujoyg wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
sujoyg:jsonschema-precommit-check
Open

chore: Add precommit checks for JSON schema.#389
sujoyg wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
sujoyg:jsonschema-precommit-check

Conversation

@sujoyg
Copy link
Copy Markdown

@sujoyg sujoyg commented Apr 27, 2026

Description

Add precommit check for JSON schema.

This check already found an issue of missing required version field in OpenRPC and OpenAPI service schemas.

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

#388

Checklist

  • I have followed the Contributing Guide.
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Screenshots / Logs (if applicable)

@sujoyg sujoyg requested review from a team as code owners April 27, 2026 08:45
@ptiper ptiper requested review from damaz91 and removed request for aksbro-gpu, knightlin-shopify and richmolj April 27, 2026 09:27
@ptiper ptiper added the devops label Apr 27, 2026
@wry-ry
Copy link
Copy Markdown
Collaborator

wry-ry commented Apr 28, 2026

Thank you for your submission. The version is injected into the JSON files when the site is generated, see https://ucp.dev/draft/services/shopping/mcp.openrpc.json for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants