fix(openapi): add missing signature headers to get_order 200 response#422
Open
paragsam wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
fix(openapi): add missing signature headers to get_order 200 response#422paragsam wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
paragsam wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
The get_order operation was the only endpoint missing the standard Signature, Signature-Input, and Content-Digest response headers declared via component refs. This omission caused OpenAPI code generators to exclude signature header access for order responses and contradicted the consistent header pattern across all other operations. Fixes Universal-Commerce-Protocol#364
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364
The
get_orderoperation (GET /orders/{id}) was the only endpoint missing the standard signature response headers present in all other operations.Added to the
get_order200 response:Signature→#/components/headers/signatureSignature-Input→#/components/headers/signature_inputContent-Digest→#/components/headers/content_digestNo new components introduced — these $refs already exist and are used by every other operation. JSON remains valid.