Codex [ FastAPI ] Add request ID middleware for log correlation#1151
Closed
cerredz wants to merge 1 commit into
Closed
Codex [ FastAPI ] Add request ID middleware for log correlation#1151cerredz wants to merge 1 commit into
cerredz wants to merge 1 commit into
Conversation
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #797
Summary:
RequestIDMiddlewareas a pure ASGI middleware that preserves client-providedX-Request-IDvalues or generates UUID request IDs.request.state.request_idand echoes it on the response header.contextvarsand a log record factory so records exposerequest_idduring request handling without leaking between requests.Validation:
uv run python -m pytest tests/test_request_id_middleware.py -quv run ruff check fastapi/middleware/request_id.py fastapi/logger.py tests/test_request_id_middleware.pyuv run ruff format --check fastapi/middleware/request_id.py fastapi/logger.py tests/test_request_id_middleware.pypython -m compileall -q fastapi/middleware/request_id.py fastapi/logger.py tests/test_request_id_middleware.pygit diff --check HEAD~1..HEADNote: I intentionally did not add
_provenance.jsonbecause it asks for full prompt/runtime/session provenance rather than product code.