fix: [ Crypto ] Fix phantom reward accrual after period expiry in YieldVault#1159
Closed
Mira-Mjodheim wants to merge 1 commit into
Closed
fix: [ Crypto ] Fix phantom reward accrual after period expiry in YieldVault#1159Mira-Mjodheim wants to merge 1 commit into
Mira-Mjodheim wants to merge 1 commit into
Conversation
…ldVault Reading all three files against the issue requirements. **Contract analysis:** **1. `lastTimeRewardApplicable()` (line 39–41)** — Correctly returns `min(block.timestamp, periodFinish)`, capping accu
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914
Reading all three files against the issue requirements.
Contract analysis:
1.
lastTimeRewardApplicable()(line 39–41) — Correctly returnsmin(block.timestamp, periodFinish), capping accumulation at period end. ✅2.
rewardPerToken()(lines 43–48) — UseslastTimeRewardApplicable()instead of rawblock.timestamp. AfterperiodFinish, delta is zero, so stored value freezes. No underflow risk:lastUpdateTimeis always set tolastTimeRewardApplicable()by the modifier, solastTimeRewardApplicable() >= lastUpdateTimealways holds. ✅3.
earned()(lines 50–52) — DChanged Files
solidity/contracts/YieldVault.solsolidity/contracts/_contributor.jsonsolidity/test/Test Results