pdnkit: CavityModel can use Djordjevic-Sarkar dielectric#38
Open
UnsignedChad wants to merge 1 commit into
Open
pdnkit: CavityModel can use Djordjevic-Sarkar dielectric#38UnsignedChad wants to merge 1 commit into
UnsignedChad wants to merge 1 commit into
Conversation
Adds a wideband_dielectric flag + DS params (eps_inf, delta_eps, f1, f2) to CavityConfig. When set, cavity_impedance() pulls eps_r(f) and eps_r"(f) from dj_sarkar_at at each frequency instead of using the constant eps_r + tan_delta. Default off so existing tests + behavior are unchanged. 4 new validation tests in [cavity-ds][validation]: * default (off) matches the constant-eps path bit-for-bit * f << f1 matches constant model with eps_r = eps_inf + delta_eps * f >> f2 matches constant model with eps_r = eps_inf * wideband peak shifts off the constant-eps peak frequency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
wideband_dielectricflag + DS params (eps_inf,delta_eps,f1,f2) toCavityConfig. When enabled,cavity_impedance()pullseps_r'(f)andeps_r"(f)fromdj_sarkar_atat each frequency instead of using the constanteps_r+tan_delta. Default off so existing tests and behavior are unchanged.Adds 4 validation tests in
[cavity-ds][validation]:f << f1matches the constant-eps model witheps_r = eps_inf + delta_epsf >> f2matches the constant-eps model witheps_r = eps_inf585 total tests, all green.