pdnkit GUI: editable layer thickness on LayerPanel#54
Open
UnsignedChad wants to merge 1 commit into
Open
Conversation
The thickness column in the Layers dock was a read-only label. Now it is a QDoubleSpinBox: edit the value and a new thickness_changed signal fires. MainWindow listens and writes the new thickness into board_->stackup.layers[i].thickness so the next analysis sees it. In-memory only -- the change does not save back to the .kicad_pcb file. Persisting requires an S-expression emitter in circuitcore::sexpr (read-only today); that is a separate PR. Useful for: trying alternate stackups quickly (1 oz vs 2 oz copper, different substrate thickness) without re-spinning the board file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thickness column in the Layers dock was a read-only label. It's now a
QDoubleSpinBox: edit the value and a newthickness_changedsignal fires. MainWindow listens and writes the new thickness intoboard_->stackup.layers[i].thicknessso the next analysis picks it up.In-memory only -- the change does not save back to the .kicad_pcb file. Persisting requires an S-expression emitter in
circuitcore::sexpr(read-only today); that's a separate PR.Useful for: trying alternate stackups quickly (1 oz vs 2 oz copper, different substrate thickness) without re-spinning the board file in KiCad. The status bar confirms the override each time.