[Docs] Work order 02: memory note recording the outcome, measured numbers, and vendoring pins - #294
Merged
vedanshujain merged 2 commits intoSep 20, 2026
Conversation
…d the two that don't Closes the plan's definition-of-done item 13 with a backward-looking record beside the forward-looking plan it closes out: the outcome, the measured numbers behind R2/R3/R6/R7, the pinned host SHAs and migration number, the conflict resolutions, and what Phase D deleted. Every figure is cited to the artefact it came from. R2 (CAS contention) and R3 (document size) have real, asserted, in-repo numbers, taken from the live tables in packages/store-emdash/README.md rather than ADR-0019's, which predate the ceiling raise from 12 to 24. R2's adversarial merchant shape is recorded as the documented exception it is. R6 and R7 are recorded as gaps rather than filled with estimates. R6 has one real before/after from INC-A6 (+11.05 kB raw, +4.15 kB gzip for admitting the domain and the store adapter) but no figure for the fully-folded Worker with the payment gateways, and nothing at INC-B10a where the plan asked for it. R7's writes/second was never measured anywhere -- the D1 tier explicitly proves primitive correctness and disclaims performance. An invented number in a historical record is worse than an acknowledged gap, so both say so plainly. Section 6 is reserved, and left empty, for the vendor/README.md content INC-D6 will move here when it deletes vendor/. Section 5 says INC-D6 has not run rather than guessing at what it will find. No README pointer: README has no further-reading or history section and links neither plans/ nor docs/, so adding one would have been forcing a fit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQbJYWWm8tf8owshm7XRp8
…mbers two reviews caught
Revision round on INC-D5 against two independent REQUEST-CHANGES reviews whose
findings converged. Every fix was re-verified against the source rather than
against the reviews.
- HttpCommerceClient was NOT "verified absent". The class definition is gone,
but live docs still describe it as current: CLAUDE.md lines 37/52/95 (the
HTTP-task verification path, "need a backing service", "reaches the service
only via ctx.http"), packages/plugin/README.md:15 ("Transitional") and
packages/plugin/test/contracts/README.md:5. Named as an open follow-up, with
the changeset/ADR-0002/ADR-0007/plans-archive hits called out as legitimately
historical. The §4 INC-D3c row no longer claims CLAUDE.md was fully swept.
- R2 measured depths topped out at 9-11 and understated the worst case. Added
the three deeper recorded shapes from store-emdash's per-shape table: restock
+10 racing 40 reserves = 13, sequenced restock then 40 reserves = 12, and 20
removals racing 20 reserves = 15.
- The adversarial-exception section mixed eras. The 11-29 typed contention
failures are the PRE-raise 12-attempt measurement; split pre-raise from
current and added the live figure that was missing entirely — 15 of 24
attempts, 0 typed failures, asserted at <= 90.
- The equivalence proof was not INC-B10c's alone. INC-A7 found only 28 of 165
HTTP assertions were transport-agnostic, so each increment added its own
slice: B10a, B10b-i/ii, B10c-i (#272) and B10c-ii (#273). Also restored the
truncated #293 title.
- INC-A6 is PR #252 alone; #251 is INC-A5 (boundary amend + ADR-0018).
- payments-stripe entered the perimeter at INC-C1b/#276; payments-x402 entered
separately at INC-C5/#281 (commit 5f304d1), when the in-process settle path
made x402-wiring a real runtime import. The R6 bundle caveat is unchanged.
- The summary blockquote said R6 "does not" have a real number while §R6 calls
the +4.15 kB delta real; reworded to "neither has the figure the plan asked
for" so the file stops contradicting itself.
- §1 recorded only wins. Added the accepted cost per ADR-0020 §2: the Stripe
secret's trust surface widened into the plugin's kv, bounded but stored
without a live consuming payment path (payments-stripe still defaults to
globalThis.fetch, not ctx.http.fetch).
Verification: pnpm lint, typecheck, format:check and changeset status all clean.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CQbJYWWm8tf8owshm7XRp8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
plans/work-order-02-fold-service-into-plugin-memory.md, a durable historical record of this work order's outcome: one deployable, with the plugin owning commerce truth in-process.The note records:
Verification
lint,typecheck,format-check, andchangeset-statusall pass locally on this single-file, docs-only diff.Follow-ups surfaced by review, out of this PR's scope
HttpCommerceClientreferences remain inCLAUDE.mdand in the plugin's own README/contracts-README — needs a follow-up sweep.CAS_MAX_ATTEMPTS = 12citation inpackages/store-emdash/README.mdneeds a one-line fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01CQbJYWWm8tf8owshm7XRp8