[CI] Drop stale service references from domain-is-io-free and store-emdash-is-sandbox-clean - #299
Open
sumeethofficial-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291
What
@otta-sh/servicewas deleted in INC-D3b, but two dependency-cruiser rules still named it. This removes those references.domain-is-io-free: droppedservicefrom theto.pathregex and the comment.store-emdash-is-sandbox-clean: droppedservicefrom all threeto.pathclauses and reworded the comment.TODO(#291)markers.Nothing is left unguarded
The family-level bans still cover both rules:
store-[^/]+andpayments-[^/]+(plus the(?!store-emdash…)lookahead) are unchanged, so a reintroducedstore-postgresis still forbidden on the day it is created. A reintroducedservicepackage is deliberately not banned by name, matching the decision already documented inplugin-is-sandbox-clean.Tests
Added cases to
depcruise-boundary.test.ts:domain-is-io-freehad no coverage before)Verified locally:
pnpm lint,pnpm typecheck,pnpm format, and the boundary suite (19/19 passing).No changeset: no published package source changed.