fix(mcp): report completed connected tool - #1964
Open
dhairyashiil wants to merge 1 commit into
Open
Conversation
Author
|
@RhysSullivan could you please check and let me know if this makes sense? let me know if you need any changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
toolNameto successful MCPexecuteresults when a script uses exactly one distinct connected tool.This gives MCP clients structured provenance for a completed result without changing the existing text result. Discovery and built-in calls, failed calls, and executions that use multiple distinct connected tools remain unlabeled. The internal per-call trace is not returned in the MCP response.
Review guide
tool-invokerrecords a dynamic connected-tool path only after a successful call.enginekeeps that trace internal and projectstoolNameonly when one distinct path was used.Verification
npx bun@1.3.11 run format:checknpx bun@1.3.11 run lintnpx bun@1.3.11 run typechecknpx bun@1.3.11 run testnpx bun@1.3.11 run --cwd e2e test:selfhost -- scenarios/tool-call-contract.test.ts