Skip to content

Document overlay 13#370

Merged
UsernameFodder merged 3 commits intoUsernameFodder:masterfrom
Chesyon:personality-test
Mar 25, 2026
Merged

Document overlay 13#370
UsernameFodder merged 3 commits intoUsernameFodder:masterfrom
Chesyon:personality-test

Conversation

@Chesyon
Copy link
Copy Markdown
Contributor

@Chesyon Chesyon commented Mar 24, 2026

  • Documented every ov13 function
  • Documented every ov13 symbol except OVERLAY13_UNKNOWN_STRUCT__NA_238CF14 because I still don't know what's going on there
  • Documented an enum for the state of the personality test
  • Document most fields of the main personality test struct

#ifndef HEADERS_DATA_OVERLAY13_H_
#define HEADERS_DATA_OVERLAY13_H_

extern struct window_params QUIZ_WINDOW_PARAMS_1;
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add aliases for these; the old names are comprehensible enough that we should try not to break them. The only ones I'd be fine breaking here are the ones with hex addresses directly in the name

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do aliases need to be added to the headers as well? If so, I'm not familiar with how to do that.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just the symbol tables. Header aliases are generated automatically in the release package.

@UsernameFodder UsernameFodder merged commit 72a9138 into UsernameFodder:master Mar 25, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants