fix: fetch full user object from MongoDB in protect middleware to populate username#210
Merged
Merged
Conversation
|
@vedant-kawale-27 is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Userunknown84
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where requests forwarded to the Flask ML API contained
X-User-Username: undefinedin the headers.The
protectmiddleware was previously assigning the decoded JWT payload{ id: userId }directly toreq.userwithout querying the database. Consequently, references toreq.user.usernamereturnedundefined. This PR modifies the middleware to retrieve the complete user document from MongoDB.Changes
Usermodel import inbackend/middleware/authMiddleware.js.protectmiddleware to beasync.User.findById(decoded.id).select('-password')to retrieve the user's complete data from MongoDB.401 User not found.response if the user no longer exists in the database.req.user: Assigned the retrieved user document toreq.usersoreq.user.usernameand other properties are correctly populated.Verification
protect:closes #174