fix: internal microservice authentication for Gmail/Outlook scanning APIs#212
Merged
Userunknown84 merged 1 commit intoJun 23, 2026
Merged
Conversation
|
@onkar0127 is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Userunknown84
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #147
Description
This Pull Request introduces a secure internal shared-secret authentication mechanism (Option A) between the Node.js API Gateway and the Python Flask ML API.
Previously, several endpoints (including
/gmail/callback,/gmail/emails,/outlook/callback,/outlook/emails, and/scan-emails) were decorated with@jwt_required(). Because the Node.js backend does not forward a Flask-signed JWT token, all internal requests initiated by the Node backend failed immediately with401 Unauthorizedresponses.By implementing a shared internal secret checking mechanism:
X-Internal-Secret.X-User-Usernameheader instead ofget_jwt_identity()./imap/...routes, which previously had no validation.Key Changes
backend/server.js):X-Internal-Secretheader on all outgoing Flask API calls.backend/api.py):@jwt_or_secret_required()custom decorator.get_current_user_identity()helper to resolve identity fromX-User-Usernamewhen the secret matches, falling back to standardget_jwt_identity()otherwise./imapendpoints' identity check (_require_username()) to also verifyX-Internal-Secretfor consistency.backend/tests/test_internal_secret.py):Verification Results
All tests ran successfully with zero regressions:
pytest backend/tests/test_internal_secret.py: 6 passed / 6 totalpytest backend/tests: 59 passed / 59 total