Remove dead SorobanTraceLayer (fixes #240) - #264
Merged
elizabetheonoja-art merged 1 commit intoAug 29, 2026
Merged
Conversation
src/tracing/lib.rs was never declared in src/tracing/mod.rs, so it was never compiled into the crate — unreachable, not just unused. It was an incomplete first attempt at Soroban trace-context injection (its own comment called it a placeholder). That problem is already solved by the mechanism that actually shipped: soroban_propagator::inject_context, called from blockchain/soroban/client.rs, with context recovered on-chain by SorobanEventPoller. Distributed tracing itself (issue Utility-Protocol#240) was implemented under Utility-Protocol#108/PR Utility-Protocol#210, with correlation-ID propagation following 9 days before this audit. See NOTES.md for the full audit.
elizabetheonoja-art
merged commit Aug 29, 2026
00e4c1f
into
Utility-Protocol:main
3 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/tracing/lib.rs was never declared in src/tracing/mod.rs, so it was never compiled into the crate unreachable, not just unused. It was an incomplete first attempt at Soroban trace-context injection (its own comment called it a placeholder).