Fix KYC-transfer test gap, unknown contract errors, expiry docs, carbon standard allowlist - #729
Merged
abore9769 merged 2 commits intoSep 1, 2026
Conversation
…standard allowlist - Add integration test asserting transfer to a non-KYC recipient is rejected with KycNotApproved (closes VERITOKEN-xx#666) - Make parseContractError return a well-defined UnknownContractError fallback instead of silently degrading for unmapped codes (closes VERITOKEN-xx#667) - Document the unit of allowance/KYC expiry fields to prevent mixing ledger-sequence and UNIX-timestamp time domains (closes VERITOKEN-xx#668) - Restrict carbon standard metadata to a known allowlist (VCS, Gold Standard, CDM, ACR, CAR) (closes VERITOKEN-xx#669)
|
@kanengchik Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KycNotApproved.parseContractErrornow returns a well-definedUnknownContractErrorfallback instead of silently degrading when a contract error code isn't in the lookup table.expiration_ledger(ledger sequence) in rwa-token andexpiry(UNIX timestamp) in kyc-registry to prevent mixing time domains.validateCarbonStandardvalidator.Closes #666
Closes #667
Closes #668
Closes #669
Test plan
cargo test -p integration-tests --features testutilsnpm testinsdknpm testinfrontend