fix: make Windows setup launcher CI-tested - #5
Merged
Conversation
VVeb1250
force-pushed
the
fix/windows-npx-installer
branch
from
August 12, 2026 04:28
cbf9ceb to
88e7ba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows setup failures where spawning npx.cmd with shell:false returned EINVAL. WhipUI now launches npx through cmd.exe with shell:false and windowsHide, preserving argument boundaries without using the deprecated shell=true path. Adds a real npx launcher regression test and a windows-latest CI matrix across Node 18/20/22 that validates the setup plan and project-local Codex, VS Code, and Claude MCP configs.