build: Split integration CI - #129
Conversation
There was a problem hiding this comment.
Pull request overview
Splits integration testing into a dedicated workflow and enables explicit payjoin-cli tests.
Changes:
- Adds scheduled/manual integration CI.
- Updates payjoin-cli test configuration and explicit tests.
- Pins GitHub Actions to immutable SHAs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/integration.yml |
Adds dedicated integration workflow. |
.github/workflows/build.yml |
Retains build and unit tests only. |
.github/workflows/package.yml |
Pins package workflow actions. |
.github/workflows/codeql.yml |
Pins CodeQL actions. |
.github/actions/prepare-ci-build/action.yml |
Pins setup and cache actions. |
PayjoinCliIntegrationTests.cs |
Marks CLI tests explicit. |
TestUtils/PayjoinCliPayer.cs |
Updates CLI configuration API. |
TestUtils/PayjoinCliIntegrationTestSupport.cs |
Adapts CLI payer invocation. |
TestUtils/PayjoinInvoiceTestHelper.cs |
Removes unused directory accessor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
@ValeraFinebits Do you intend to stop running integration on PRs and merges? integration.yml only has schedule and workflow_dispatch, and build.yml now runs unit tests only.
The integration suite is the only cover for the real flow. On #113 it caught the receiver stripping HD keypaths, so the sender could not sign its own input; no unit test finds that.
If per-PR is too slow, push: branches: [master] at least names the merge that broke it.
67d494a to
55cf735
Compare
@chavic integration.yml now runs on pull_request again, so regular integration coverage stays on PRs; only the explicit/heavier concurrency and payjoin-cli cases are kept out of the default PR run for scheduled/manual execution. |
|
ACK This should be fine for now, but something came up. Every push drives traffic to other people's directories; I want to make a note that this is probably something to change in the future |
No description provided.