Skip to content

build: Split integration CI - #129

Merged
ValeraFinebits merged 2 commits into
masterfrom
build/Split-integration-CI
Aug 15, 2026
Merged

ValeraFinebits merged 2 commits into
masterfrom
build/Split-integration-CI

Conversation

@ValeraFinebits

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Splits integration testing into a dedicated workflow and enables explicit payjoin-cli tests.

Changes:

  • Adds scheduled/manual integration CI.
  • Updates payjoin-cli test configuration and explicit tests.
  • Pins GitHub Actions to immutable SHAs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/integration.yml Adds dedicated integration workflow.
.github/workflows/build.yml Retains build and unit tests only.
.github/workflows/package.yml Pins package workflow actions.
.github/workflows/codeql.yml Pins CodeQL actions.
.github/actions/prepare-ci-build/action.yml Pins setup and cache actions.
PayjoinCliIntegrationTests.cs Marks CLI tests explicit.
TestUtils/PayjoinCliPayer.cs Updates CLI configuration API.
TestUtils/PayjoinCliIntegrationTestSupport.cs Adapts CLI payer invocation.
TestUtils/PayjoinInvoiceTestHelper.cs Removes unused directory accessor.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/integration.yml

@chavic chavic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValeraFinebits Do you intend to stop running integration on PRs and merges? integration.yml only has schedule and workflow_dispatch, and build.yml now runs unit tests only.

The integration suite is the only cover for the real flow. On #113 it caught the receiver stripping HD keypaths, so the sender could not sign its own input; no unit test finds that.

If per-PR is too slow, push: branches: [master] at least names the merge that broke it.

@ValeraFinebits
ValeraFinebits force-pushed the build/Split-integration-CI branch from 67d494a to 55cf735 Compare August 15, 2026 13:02
@ValeraFinebits

Copy link
Copy Markdown
Owner Author

@ValeraFinebits Do you intend to stop running integration on PRs and merges? integration.yml only has schedule and workflow_dispatch, and build.yml now runs unit tests only.

The integration suite is the only cover for the real flow. On #113 it caught the receiver stripping HD keypaths, so the sender could not sign its own input; no unit test finds that.

If per-PR is too slow, push: branches: [master] at least names the merge that broke it.

@chavic integration.yml now runs on pull_request again, so regular integration coverage stays on PRs; only the explicit/heavier concurrency and payjoin-cli cases are kept out of the default PR run for scheduled/manual execution.

@ValeraFinebits
ValeraFinebits requested a review from chavic August 15, 2026 13:34
@chavic

chavic commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

ACK

This should be fine for now, but something came up. Every push drives traffic to other people's directories; I want to make a note that this is probably something to change in the future

@ValeraFinebits

Copy link
Copy Markdown
Owner Author

ACK

This should be fine for now, but something came up. Every push drives traffic to other people's directories; I want to make a note that this is probably something to change in the future

@chavic This will be fixed here #109

@ValeraFinebits
ValeraFinebits merged commit be3fa0b into master Aug 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants