build(deps): bump rust-payjoin from a5ff964 to b02a6cc - #148
Open
dependabot[bot] wants to merge 2 commits into
Open
dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [rust-payjoin](https://github.com/payjoin/rust-payjoin) from `a5ff964` to `b02a6cc`. - [Release notes](https://github.com/payjoin/rust-payjoin/releases) - [Commits](payjoin/rust-payjoin@a5ff964...b02a6cc) --- updated-dependencies: - dependency-name: rust-payjoin dependency-version: b02a6ccb02392e8b986092fb5c035519f9fe1fbe dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
ValeraFinebits
marked this pull request as draft
August 17, 2026 17:39
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps rust-payjoin and adapts the plugin to its outpoint-based input ownership API.
Changes:
- Resolves input ownership using NBXplorer transaction history.
- Separates input and output ownership resolvers.
- Adds unit and integration coverage for spent and cold-wallet outpoints.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
rust-payjoin |
Updates the dependency revision. |
PayjoinWalletOwnershipIntegrationTests.cs |
Tests outpoint ownership through NBXplorer. |
PayjoinReceiverStateProcessorTests.cs |
Tests callbacks and transaction extraction. |
IPayjoinReceiverStateProcessor.cs |
Adds original transaction facts and resolver state. |
PayjoinReceiverSessionGuard.cs |
Restores input and output facts during replay. |
PayjoinReceiverStateProcessor.cs |
Uses outpoint-based input ownership callbacks. |
PayjoinWalletOwnershipService.cs |
Resolves ownership from wallet transaction history. |
Suppressed comments (1)
BTCPayServer.Plugins.Payjoin/Services/PayjoinWalletOwnershipService.cs:149
- A null derivation match is treated as foreign here. While NBXplorer is still syncing or a newly tracked hot/cold derivation lacks authoritative history, a receiver-signable outpoint can produce exactly this result, so
CheckInputsNotOwnedaccepts the receiver's own input. Verify wallet-history readiness before resolving, or preserve an Unknown state and reject/defer the proposal instead of failing open.
// TODO(security): Do not collapse an NBXplorer no-match into Foreign while wallet
// ownership readiness is unverified. Represent it as Unknown and fail closed until
// the relevant hot/cold derivation histories are known to be authoritative.
if (matchedOutputs is null)
{
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
A newer version of rust-payjoin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rust-payjoin from
a5ff964tob02a6cc.Commits
b02a6ccchore: update flake.lock (#1808)ff34866chore: update flake.lockf00cc66Allow double must_use lint9c089f8chore: update cargo.lock (#1807)4491960chore: update cargo.lockf4f3114Use a single release environment for publishing (#1806)c3b27a4Remove flakehub api call in nix cache action in CI (#1798)e3300dbGitHub app bot (#1805)49876cdRename formatting CI action4dee3d3Disable flakehub api in nix cache actionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)