Skip to content

build(deps): bump rust-payjoin from a5ff964 to b02a6cc - #148

Open
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/submodules/rust-payjoin-b02a6cc
Open

dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/submodules/rust-payjoin-b02a6cc

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bumps rust-payjoin from a5ff964 to b02a6cc.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rust-payjoin](https://github.com/payjoin/rust-payjoin) from `a5ff964` to `b02a6cc`.
- [Release notes](https://github.com/payjoin/rust-payjoin/releases)
- [Commits](payjoin/rust-payjoin@a5ff964...b02a6cc)

---
updated-dependencies:
- dependency-name: rust-payjoin
  dependency-version: b02a6ccb02392e8b986092fb5c035519f9fe1fbe
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Aug 17, 2026
@ValeraFinebits ValeraFinebits self-assigned this Aug 17, 2026
@ValeraFinebits
ValeraFinebits marked this pull request as draft August 17, 2026 17:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps rust-payjoin and adapts the plugin to its outpoint-based input ownership API.

Changes:

  • Resolves input ownership using NBXplorer transaction history.
  • Separates input and output ownership resolvers.
  • Adds unit and integration coverage for spent and cold-wallet outpoints.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rust-payjoin Updates the dependency revision.
PayjoinWalletOwnershipIntegrationTests.cs Tests outpoint ownership through NBXplorer.
PayjoinReceiverStateProcessorTests.cs Tests callbacks and transaction extraction.
IPayjoinReceiverStateProcessor.cs Adds original transaction facts and resolver state.
PayjoinReceiverSessionGuard.cs Restores input and output facts during replay.
PayjoinReceiverStateProcessor.cs Uses outpoint-based input ownership callbacks.
PayjoinWalletOwnershipService.cs Resolves ownership from wallet transaction history.
Suppressed comments (1)

BTCPayServer.Plugins.Payjoin/Services/PayjoinWalletOwnershipService.cs:149

  • A null derivation match is treated as foreign here. While NBXplorer is still syncing or a newly tracked hot/cold derivation lacks authoritative history, a receiver-signable outpoint can produce exactly this result, so CheckInputsNotOwned accepts the receiver's own input. Verify wallet-history readiness before resolving, or preserve an Unknown state and reject/defer the proposal instead of failing open.
        // TODO(security): Do not collapse an NBXplorer no-match into Foreign while wallet
        // ownership readiness is unverified. Represent it as Unknown and fail closed until
        // the relevant hot/cold derivation histories are known to be authoritative.
        if (matchedOutputs is null)
        {

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ValeraFinebits
ValeraFinebits marked this pull request as ready for review August 17, 2026 21:22
@ValeraFinebits
ValeraFinebits requested a review from chavic August 17, 2026 21:22
@ValeraFinebits ValeraFinebits removed their assignment Aug 20, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

A newer version of rust-payjoin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants