Fix context submenus overflowing past the bottom edge - #1672
Open
SigmaTel71 wants to merge 1 commit into
Open
Conversation
…o test Submenus near the bottom of the viewport could render past the bottom edge because they anchor via `bottom: -50%` off their parent button and only the top-overflow case was corrected. Adds the missing bottom-edge check and pulls the shared correction math into an exported function so it's unit-testable without a DOM, plus a demo/regression test covering all four edges (Valour-Software#1622).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrial of #1666 with all review suggestions applied.
The PR includes a test suite for boundary calculations, as well as the fix for the bottom part boundary check. Originally authored by @LuisMend12, I got explicit permission from him to recover the patch and bring it on my own.
I will test the code on my own and edit the opening message with the demo in a few hours.