Skip to content

feat: Add Delete Button for Strategy Prompts#542

Merged
DigHuang merged 4 commits into
ValueCell-ai:mainfrom
PotatoZhou:main
Dec 8, 2025
Merged

feat: Add Delete Button for Strategy Prompts#542
DigHuang merged 4 commits into
ValueCell-ai:mainfrom
PotatoZhou:main

Conversation

@PotatoZhou

Copy link
Copy Markdown
Contributor

📝 Pull Request Template

1. Related Issue

Closes #527

2. Type of Change (select one)

Type of Change: New Feature

3. Description

Add Delete Button for Strategy Prompts

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

@vcfgv

vcfgv commented Dec 6, 2025

Copy link
Copy Markdown
Collaborator

Thank you for the contribution!

Could you please attach a screenshot or a brief demo showing what the frontend looks like with the new Delete button? It would be helpful to visualize the changes.

@PotatoZhou

Copy link
Copy Markdown
Contributor Author

sure will do :)

@PotatoZhou

Copy link
Copy Markdown
Contributor Author
Screen Shot 2025-12-06 at 16 03 33 Screen Shot 2025-12-06 at 16 01 33

As shown in the figure, The delete button will appear on hover, and a confirmation dialog will pop up when clicked. The prompt will only be deleted once the user clicks the 'Confirm Delete' button.

@vcfgv

vcfgv commented Dec 6, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the feedback! Please confirm whether these two icons are properly aligned.

image

@PotatoZhou

Copy link
Copy Markdown
Contributor Author
Screen Shot 2025-12-07 at 00 42 12

The delete icon and select icon are now properly aligned as shown in the figure, as they now have matching container sizes

@vcfgv

vcfgv commented Dec 7, 2025

Copy link
Copy Markdown
Collaborator

@DigHuang Do you have any comments?

@DigHuang

DigHuang commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

no problem

DigHuang
DigHuang previously approved these changes Dec 8, 2025

@DigHuang DigHuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DigHuang DigHuang merged commit 3d02f18 into ValueCell-ai:main Dec 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Delete Button for Strategy Prompts

3 participants