Fix Widget Selector loading without legacy fonts include - #3
Draft
Dimaris-nsk wants to merge 1 commit into
Draft
Dimaris-nsk wants to merge 1 commit into
Dimaris-nsk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Widget Selector fails to initialize because it includes
LuaUI/fonts.lua,which is absent from the tested BAR package. Remove that one unused include:
the selector loads its own fonts with
gl.LoadFontand does not use the oldfontHandler.Test steps
Completed by Codex in real macOS v0.15.1 BAR with separate original/fixed game
packages based on
test-31251-0ceadc7, on All That Smolders v1.2:fonts.lualoaderror and has no initialized instance.
BuildETAandclearing the search work.
the initial enabled state is restored.
/luaui reload, reopen and closethe list, then move the camera again. BuildETA remains enabled with one
instance after reload; Widget Selector loads successfully both times.
emergency termination.
Both complete Lua files also compile under Lua 5.1. A focused check using the
pinned loader's compile/setfenv/pcall fragment rejects the original startup
prefix and accepts the candidate; the real-game run covers initialization/UI.
Only the selector entry differs between the two test archives; the other
18,468 entries are identical. This validates the component on that game package,
not the entire fork distribution or an online match. Existing driver/game
warnings remain, including a 2793 ms draw gap during LuaUI reload; no new
selector loading error was found.
Native screenshots, selected logs and recorded states.
AI / LLM usage statement
OpenAI Codex performed the source analysis, one-line change, checks, live game
control and this write-up; another Codex agent reviewed the source and saved
evidence. Human verification is still pending. This draft follows our agreed
review route through Vandomas; the account owner is not represented as having
independently reviewed or tested the code. Images are actual game captures.