Restore missing wreck model used by corfast and corhack - #4
Draft
Dimaris-nsk wants to merge 1 commit into
Draft
Dimaris-nsk wants to merge 1 commit into
Dimaris-nsk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
corfast_deadandcorhack_deadstill referenceobjects3d/Units/corfast_dead.s3o, but the model is missing. BAR consequently removes both feature definitions and the engine clears the units' wreck references. Restore the one unchanged historical model so both existing definitions can load again.The 65,892-byte file is identical to upstream blob
645778f5c54241d08b3969a1db0ca388effb890c, from commit165bb063ed5221ff630abab85cb297a74a6f65ae, before its removal in PR5881. Both textures already exist. No UnitDefs, balance values, validator, engine or launcher changes are included.Test steps
Completed by Codex in one private BAR
test-31251-0ceadc7match on the v0.15.1 macOS engine, with only this model added to the game package. All 18,469 original package entries were preserved. The saved original full-game log establishes the missing definitions; original unit deaths were not observed.corfastandcorhack: both corresponding textured wrecks appear, with runtime metal/health 126/830 and 756/1830.cornecrothe ordinary Resurrect order oncorhack_dead: observe progress and a new livingcorhack, followed by normal repair.corfast_deadintocorfast_heap: observe the expected nonblocking heap, 52 metal, and no resurrection target.The isolated setup used a spectator, two idle AIs, cheats for fixture creation, and normal UI builder orders. The single native
reducewreckscommand was guarded by a complete inventory: 157 unchanged rocks and exactly one affected corpse. No observer code created features or altered progress.This covers both deaths, one resurrection and one heap/reclaim chain; it is not every lifecycle combination, a full fork distribution, or online compatibility. Existing diagnostics remain. The
xplomed2warning during death is explained by this test'sSound=0/NullSound lookup; the actual sound alias and WAV are present. Audio playback was not tested.Evidence
Reviewed screenshots, source-bound results and log excerpts.
Review requested / AI usage
The reason for the historical model deletion is unknown. Please review whether restoring the existing artwork is the intended repair for the surviving definitions.
The model is original BAR artwork, restored byte-for-byte, not AI-generated or edited media. OpenAI Codex performed the source analysis, restoration, private gameplay checks and documentation. Submitted as a draft for human review through our agreed fork workflow; independent human verification is still pending.