fix(logging): split into logging-operator + logging-config kustomizations#153
Merged
Conversation
…stomizations PR #152 landed but the single Flux Kustomization failed at first apply: the Logging/ClusterFlow/ClusterOutput CRs reference CRDs that don't exist until the logging-operator HelmRelease completes, so the whole kustomization stalled on "no matches for kind Logging in version logging.banzaicloud.io/v1beta1". Cluster currently has NO log forwarding (old fluent-bit gone, new operator never installed). Split mirrors the cert-manager / certs pattern already in this repo: platform/logging/ ├── logging-operator/ (ks: no CRD deps; ships HR + CRDs) │ └── app/ │ ├── namespace.yaml │ ├── helmrelease-operator.yaml │ └── kustomization.yaml └── logging-config/ (ks: dependsOn logging-operator; ships CRs) └── app/ ├── logging.yaml ├── clusteroutput-vcflogs.yaml ├── clusterflow-all.yaml ├── README.md └── kustomization.yaml Flux's dependsOn + `wait: true` makes logging-config sit out until logging-operator reports Ready, which only happens after the HR finishes (CRDs registered, controller pod healthy). Parent platform/kustomization.yaml lists both ks paths. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughPR restructures logging infrastructure from a single Flux Kustomization into two separate components: logging-operator (operator HelmRelease setup) and logging-config (logging pipeline resources). Platform kustomization updated to reference both new resources with explicit dependency ordering. ChangesLogging operator and config split
🎯 2 (Simple) | ⏱️ ~10 minutes Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for the cluster-degraded state from #152. Mirrors the cert-manager / certs split pattern already in this repo. Single Flux Kustomization can't apply CRs and CRDs in one pass — Logging CR was failing on
no matches for kind Logging. Splitting into operator-ks (ships HR + CRDs) + config-ks (dependsOn: logging-operator, ships CRs) resolves the ordering. Cluster currently has no log forwarding — merge ASAP.Summary by CodeRabbit