fix(logging): enableRecreateWorkloadOnImmutableFieldChange#155
Merged
Conversation
Operator refused to reconcile the storageClassName drop (#154) with: "Object has to be recreated, but refusing to remove without explicitly being told so. Use logging.spec. enableRecreateWorkloadOnImmutableFieldChange to move on." StatefulSet.spec.volumeClaimTemplates is k8s-immutable. The operator's safety check is meant for production deployments with strict durability — leaving the flag false there forces a manual sts delete + PVC migration. For this homelab where the fluentd buffer is at most a few minutes of replay, the data-loss-on- recreate trade is fine. Setting the flag lets the operator delete + recreate the STS so fluentd-0 finally binds a PVC against the cluster default StorageClass (vsan) instead of the missing longhorn class. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe vcflogs Logging CRD now includes ChangesLogging Operator Workload Recreation Policy
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix #3 for the logging migration. Operator can't reconcile the storageClassName change from #154 because StatefulSet volumeClaimTemplates are immutable. The operator's safety flag must be set explicitly. For homelab fluentd buffer, the recreate-on-immutable-change trade is acceptable.
Summary by CodeRabbit