Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion worker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ COPY worker/agent/ ./
RUN CGO_ENABLED=0 GOOS=linux go build -trimpath -ldflags="-s -w" \
-o /out/scaleplex-agent ./...

FROM nvidia/cuda:12.6.3-runtime-ubuntu24.04
FROM nvidia/cuda:12.9.2-runtime-ubuntu24.04
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟑 Minor | ⚑ Quick win

Update stale base-image comment block.

FROM moved to 12.9.2, but header docs still say 12.6.3 (Line 13). Keep these in sync to avoid audit/debug confusion.

Suggested patch
-# Base: nvidia/cuda:12.6.3-runtime-ubuntu24.04 β€” ships CUDA runtime
+# Base: nvidia/cuda:12.9.2-runtime-ubuntu24.04 β€” ships CUDA runtime
πŸ“ Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FROM nvidia/cuda:12.9.2-runtime-ubuntu24.04
# Base: nvidia/cuda:12.9.2-runtime-ubuntu24.04 β€” ships CUDA runtime
πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@worker/Dockerfile` at line 33, The header comment that documents the base
image version is out of sync with the actual FROM line: update the header/docs
in the Dockerfile to reflect the new base image tag
"nvidia/cuda:12.9.2-runtime-ubuntu24.04" so the header and the FROM statement
match; locate the Dockerfile header comment (the top-of-file doc block that
currently mentions 12.6.3) and change the version text to 12.9.2 (and adjust any
related descriptive text if present) to keep documentation and the FROM
instruction consistent.

LABEL org.opencontainers.image.source=https://github.com/Varashi/scaleplex
LABEL org.opencontainers.image.description="scaleplex worker β€” scaleplex-ffmpeg + Intel VAAPI + NVIDIA NVENC + Go agent"
LABEL org.opencontainers.image.licenses=MIT
Expand Down
Loading