Skip to content

Fix/mypy schema types#52

Merged
kohankhaki merged 3 commits into
mainfrom
fix/mypy-schema-types
Jan 27, 2026
Merged

Fix/mypy schema types#52
kohankhaki merged 3 commits into
mainfrom
fix/mypy-schema-types

Conversation

@kohankhaki
Copy link
Copy Markdown
Contributor

@kohankhaki kohankhaki commented Jan 26, 2026

PR Type

Fix

Short Description

Add missing type annotations to schema files and base generation prompts to resolve mypy errors.

Tests Added

N/A


This change is Reviewable

@kohankhaki kohankhaki requested a review from afkanpour January 26, 2026 20:36
Copy link
Copy Markdown
Collaborator

@afkanpour afkanpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@afkanpour reviewed 9 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kohankhaki).


src/schemas/area_schemas.py line 36 at r1 (raw file):

    @classmethod
    def from_dict(cls, data: Dict[str, Any]) -> "Area":

How about we import:
from future import annotations

And then use Area without ""?

That seems cleaner. Do you agree? If so, can you please change all instances where "" is used?

Code quote:

"Area"

Replace quoted string forward references (e.g., -> "Area") with
unquoted types using PEP 563 postponed annotation evaluation.
@kohankhaki kohankhaki merged commit d09cccf into main Jan 27, 2026
1 of 2 checks passed
@kohankhaki kohankhaki deleted the fix/mypy-schema-types branch January 27, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants