Fix/mypy stage types#53
Merged
Merged
Conversation
kohankhaki
force-pushed
the
fix/mypy-stage-types
branch
from
b6c349f to
3d3aa13
Compare
- Add Optional type annotation to stage function parameters (stage2-5) - Add Capability type annotation to base stage functions - Add type annotations for list variables (capabilities, all_tasks) - Add None checks for generation_metadata dict unpacking - Add assertions before return statements to satisfy mypy
kohankhaki
force-pushed
the
fix/mypy-stage-types
branch
from
3d3aa13 to
9d3e0c7
Compare
- stage0_setup.py: Cast OmegaConf config to Dict[str, Any] - model_client_utils.py: Remove unused type: ignore comment - capability_management_utils.py: Convert set to list for return type - embedding_utils.py: Add type annotation to rep_string_order parameter
afkanpour
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Add missing type annotations to stage files (stage2-5) and base stage files to resolve mypy errors.
Tests Added
N/A