fix: resolve linting and mypy type errors in wikipedia files#56
Merged
Conversation
- Add Optional types for nullable parameters - Add type annotations for class attributes and local variables - Fix BeautifulSoup Tag type narrowing with isinstance checks - Fix generator type issues in sum() calls - Add null checks for llm_model before async calls
- Shorten long docstrings and comments (W505) - Use imperative mood in docstrings (D401) - Add period to module docstring first line (D400) - Use lowercase variable names in functions (N806) - Remove .keys() from dict iteration (SIM118) - Fix module docstring formatting (D205, D404)
kohankhaki
force-pushed
the
fix/wikipedia-types
branch
from
67a9631 to
38f3f15
Compare
kohankhaki
changed the title
False positives like 'nd' require ongoing config maintenance.
kohankhaki
force-pushed
the
fix/wikipedia-types
branch
from
20fc8a1 to
b67e121
Compare
afkanpour
approved these changes
Feb 2, 2026
Collaborator
afkanpour
left a comment
afkanpour
left a comment
There was a problem hiding this comment.
@afkanpour reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Negiiiin).
Negiiiin
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Fix linting and mypy errors in wikipedia scripts.
Tests Added
N/A
This change is