Feat/issues 264 261 259 263 - #374
Conversation
- Tests for all required field combinations - Tests for invalid type and out-of-range values - Tests for nested policy rule validation - Ensure tests run as part of existing test suite closes Vellar-Wallet#264
- Sanitize resource-provided fields such as name and description - Add tests covering script injection and malformed metadata attempts - Verify sanitized output is safe for direct rendering - Document the sanitization approach in the x402 README section closes Vellar-Wallet#261
- Add test verifying unexpected origin scenarios are handled safely - Document the origin policy in the README security section - Audit current origin-related assumptions against real consumer usage - Restrict or document the expected origin handling explicitly closes Vellar-Wallet#259
…ting guard for passkeykit-connector Vellar-Wallet#264 Add unit tests for policy-types schema validation Vellar-Wallet#261 Add input sanitization for untrusted x402 resource metadata (already implemented) Vellar-Wallet#259 Review allowed-origin assumptions in connector.ts (already implemented) Vellar-Wallet#263 Add rate limiting guard to passkeykit-connector authentication calls
|
@devfoma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@devfoma is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @devfoma — thanks for the contribution! We do not accept pull requests to the You don't need to reopen anything — your work is preserved and this PR now targets |
|
Thanks for the contribution — but contributor PRs may only change files inside This PR touches file(s) outside that folder:
Please open a new PR with your changes scoped to Questions? Ask in the Telegram group. |
2 participants
src/policy-types.test.tssrc/x402-untrusted.ts)src/passkeykit-connector.tsChanges made:
src/policy-types.test.ts- Added 6 new tests for schema validation edge casessrc/passkeykit-connector.ts- Added exportedRateLimitError,attemptCache,resetAttemptCount,incrementAttemptCount,checkRateLimitfunctionscloses #264
closes #261
closes #259
closes #263