Skip to content

Feat/delta buildCancelDeltaOrder util#246

Merged
andriy-shymkiv merged 7 commits into
masterfrom
feat/delta_buildCancelDeltaOrder-util
Jun 25, 2026
Merged

Feat/delta buildCancelDeltaOrder util#246
andriy-shymkiv merged 7 commits into
masterfrom
feat/delta_buildCancelDeltaOrder-util

Conversation

@andriy-shymkiv

@andriy-shymkiv andriy-shymkiv commented Jun 25, 2026

Copy link
Copy Markdown
Member

Adds buildCancelDeltaOrder in constructCancelDeltaOrder factory


Note

Low Risk
Additive API on the cancel path with a small internal refactor; existing cancelDeltaOrders behavior is unchanged aside from sharing the new build step.

Overview
Adds buildCancelDeltaOrder on constructCancelDeltaOrder / sdk.delta.*, returning EIP-712 SignableCancelDeltaOrderData (Portikus domain + OrderCancellations with orderIds) after resolving the ParaswapDelta contract. signCancelDeltaOrderRequest now builds typed data through this helper before calling signTypedDataCall, so apps can inspect or sign cancel payloads outside the bundled signer.

Exports the BuildCancelDeltaOrder type from the package entrypoint, documents the build → sign → post cancel flow in CLAUDE.md, bumps @velora-dex/sdk to 10.1.0, and adds unit coverage plus an assertion that constructAllDeltaOrdersHandlers exposes buildCancelDeltaOrder. README.md changes are mostly formatting; command examples use pnpm instead of yarn.

Reviewed by Cursor Bugbot for commit b0dbced. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 16.66 KB (0%)
dist/sdk.esm.js 16.91 KB (0%)

@andriy-shymkiv andriy-shymkiv requested review from Velenir and Copilot and removed request for Copilot June 25, 2026 10:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Delta cancel utility that lets consumers build (but not sign) the EIP-712 typed data needed for batch Delta order cancellations, and refactors existing cancel signing to reuse that builder. Documentation files are also reformatted/updated to describe the overall cancel pipeline.

Changes:

  • Add buildCancelDeltaOrder to the Delta cancel factory and have signCancelDeltaOrderRequest delegate to it.
  • Export the BuildCancelDeltaOrder type from the package entrypoint.
  • Extend tests and update README/CLAUDE docs to reflect the cancel/build/sign flow and formatting.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/delta.test.ts Adds coverage for the new buildCancelDeltaOrder output and SDK wiring.
src/methods/delta/cancelDeltaOrder.ts Introduces buildCancelDeltaOrder and refactors signing to call it.
src/index.ts Exports the new BuildCancelDeltaOrder public type.
README.md Reformats examples and documents the build/sign/post pipeline (but currently has a couple example typos).
CLAUDE.md Updates repo commands (pnpm) and architecture docs + formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread README.md Outdated
@andriy-shymkiv andriy-shymkiv merged commit 520e777 into master Jun 25, 2026
4 checks passed
@andriy-shymkiv andriy-shymkiv deleted the feat/delta_buildCancelDeltaOrder-util branch June 25, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants