Feat/delta buildCancelDeltaOrder util#246
Merged
Merged
Conversation
Return EIP-712 signable data via buildCancelDeltaOrderSignableData; signCancelDeltaOrderRequest reuses it. Export BuildCancelDeltaOrder type.
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
Adds a new Delta cancel utility that lets consumers build (but not sign) the EIP-712 typed data needed for batch Delta order cancellations, and refactors existing cancel signing to reuse that builder. Documentation files are also reformatted/updated to describe the overall cancel pipeline.
Changes:
- Add
buildCancelDeltaOrderto the Delta cancel factory and havesignCancelDeltaOrderRequestdelegate to it. - Export the
BuildCancelDeltaOrdertype from the package entrypoint. - Extend tests and update README/CLAUDE docs to reflect the cancel/build/sign flow and formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/delta.test.ts | Adds coverage for the new buildCancelDeltaOrder output and SDK wiring. |
| src/methods/delta/cancelDeltaOrder.ts | Introduces buildCancelDeltaOrder and refactors signing to call it. |
| src/index.ts | Exports the new BuildCancelDeltaOrder public type. |
| README.md | Reformats examples and documents the build/sign/post pipeline (but currently has a couple example typos). |
| CLAUDE.md | Updates repo commands (pnpm) and architecture docs + formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Velenir
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
buildCancelDeltaOrderinconstructCancelDeltaOrderfactoryNote
Low Risk
Additive API on the cancel path with a small internal refactor; existing
cancelDeltaOrdersbehavior is unchanged aside from sharing the new build step.Overview
Adds
buildCancelDeltaOrderonconstructCancelDeltaOrder/sdk.delta.*, returning EIP-712SignableCancelDeltaOrderData(Portikus domain +OrderCancellationswithorderIds) after resolving the ParaswapDelta contract.signCancelDeltaOrderRequestnow builds typed data through this helper before callingsignTypedDataCall, so apps can inspect or sign cancel payloads outside the bundled signer.Exports the
BuildCancelDeltaOrdertype from the package entrypoint, documents the build → sign → post cancel flow in CLAUDE.md, bumps@velora-dex/sdkto 10.1.0, and adds unit coverage plus an assertion thatconstructAllDeltaOrdersHandlersexposesbuildCancelDeltaOrder. README.md changes are mostly formatting; command examples use pnpm instead of yarn.Reviewed by Cursor Bugbot for commit b0dbced. Bugbot is set up for automated code reviews on this repo. Configure here.