vcert/v4/pkg: Expose API for refreshing the access token in Connector interface#341
Open
KalpitTiwari03 wants to merge 2 commits intoVenafi:masterfrom
Open
vcert/v4/pkg: Expose API for refreshing the access token in Connector interface#341KalpitTiwari03 wants to merge 2 commits intoVenafi:masterfrom
KalpitTiwari03 wants to merge 2 commits intoVenafi:masterfrom
Conversation
KalpitTiwari03
requested review from
EduardoVV,
luispresuelVenafi,
marcos-albornoz and
rvelaVenafi
as code owners
RefreshAccessToken() api is not exposed in Connector interface at the moment. Adding the same by introducing a wrapper over RefreshAccessToken() which returns an interface instead of tpp specific struct. Other possible approach can be - moving out the struct OauthRefreshAccessTokenResponse to endpoint.go file and add RefreshAccessToken() to Connector interface. But the stuct is TPP specific so placing it in endpoint pkg does not look right therefor going with current approac
Author
|
Could I please get a review here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"RefreshAccessToken()" api is not exposed in Connector interface at the moment. Adding the same by introducing a wrapper over "RefreshAccessToken()" which returns an interface instead of TPP specific struct.
Other possible approach can be - moving out the struct "OauthRefreshAccessTokenResponse" to endpoint.go file and add
"RefreshAccessToken()" to Connector interface. But the struct is TPP specific so placing it in endpoint pkg does not look right therefor going with current approach.